Page MenuHomePhabricator
Create Task
Maniphest T234227

Improve test coverage for FileBackend and friends
Closed, ResolvedPublic
Actions

Description

FileBackend, File, FileJournal and related classes need refactoring to detach them from global state, but they should have better test coverage first.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Unit tests for DBFileJournalSimetricalmediawiki/coremaster+311 -3
Unit test for MySqlLockManagerSimetricalmediawiki/coremaster+339 -0
100% unit test coverage for FileBackendSimetricalmediawiki/coremaster+425 -120
Hard-deprecate LockManagerGroup::getDefault/getAnySimetricalmediawiki/coremaster+27 -17
Unit tests for FileBackendSimetricalmediawiki/coremaster+829 -24
Customize query in gerrit

Event Timeline

daniel created this task.Sep 30 2019, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2019, 3:08 PM
gerritbot added a comment.Sep 30 2019, 3:08 PM

Change 533734 had a related patch set uploaded (by Daniel Kinzler; owner: simetrical):
[mediawiki/core@master] Unit tests for DBFileJournal

https://gerrit.wikimedia.org/r/533734

gerritbot added a project: Patch-For-Review.Sep 30 2019, 3:08 PM
daniel moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Sep 30 2019, 3:11 PM
daniel triaged this task as Medium priority.Sep 30 2019, 4:30 PM
gerritbot added a comment.Oct 23 2019, 9:39 AM

Change 533734 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Unit tests for DBFileJournal

https://gerrit.wikimedia.org/r/533734

• WDoranWMF moved this task from Waiting for Review to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Oct 23 2019, 4:48 PM
Simetrical subscribed.Oct 23 2019, 5:19 PM

Coverage for includes/filebackend/: 41.18% of lines (119/289)

Coverage for includes/libs/filebackend/: 52.24% of lines (1726/3304)

Doing libs/filebackend/ is a bit of a longer-term project.

gerritbot added a comment.Oct 24 2019, 9:24 AM

Change 545783 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Hard-deprecate LockManagerGroup::getDefault/getAny

https://gerrit.wikimedia.org/r/545783

Simetrical added a comment.Oct 24 2019, 9:24 AM

Coverage for includes/libs/lockmanager: 16.64% of lines (116/697)

For some reason we have includes/filebackend/lockmanager, but includes/libs/lockmanager not under filebackend.

gerritbot added a comment.Oct 27 2019, 11:46 AM

Change 546359 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Unit test for MySqlLockManager

https://gerrit.wikimedia.org/r/546359

gerritbot added a comment.Oct 30 2019, 7:35 AM

Change 547006 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Unit tests for FileBackend

https://gerrit.wikimedia.org/r/547006

gerritbot added a comment.Oct 30 2019, 11:28 AM

Change 547006 merged by jenkins-bot:
[mediawiki/core@master] Unit tests for FileBackend

https://gerrit.wikimedia.org/r/547006

gerritbot added a comment.Oct 30 2019, 11:33 AM

Change 547173 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] 100% unit test coverage for FileBackend

https://gerrit.wikimedia.org/r/547173

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Oct 30 2019, 12:00 PM
gerritbot added a comment.Oct 30 2019, 12:02 PM

Change 545783 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate LockManagerGroup::getDefault/getAny

https://gerrit.wikimedia.org/r/545783

gerritbot added a comment.Nov 1 2019, 1:47 AM

Change 547173 merged by jenkins-bot:
[mediawiki/core@master] 100% unit test coverage for FileBackend

https://gerrit.wikimedia.org/r/547173

gerritbot added a comment.Nov 1 2019, 5:08 PM

Change 546359 merged by jenkins-bot:
[mediawiki/core@master] Unit test for MySqlLockManager

https://gerrit.wikimedia.org/r/546359

• WDoranWMF moved this task from Doing(WIP:5) to Done on the Platform Team Workboards (Clinic Duty Team) board.Dec 4 2019, 7:27 PM
• CCicalese_WMF closed this task as Resolved.Apr 28 2020, 8:49 PM
• CCicalese_WMF claimed this task.
• CCicalese_WMF subscribed.

Marking as Resolved as it is in the Done column. Feel free to reopen if there is remaining work.

gerritbot added a comment.Sep 21 2021, 1:45 PM

Change 533734 abandoned by Ppchelko:

[mediawiki/core@master] Unit tests for DBFileJournal

Reason:

Ia3f59ad0ddeb1f610947b14e22b0694ff4c6ed84

https://gerrit.wikimedia.org/r/533734

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits