Page MenuHomePhabricator

Improve test coverage for FileBackend and friends
Open, MediumPublic

Description

FileBackend, File, FileJournal and related classes need refactoring to detach them from global state, but they should have better test coverage first.

Details

Related Gerrit Patches:

Event Timeline

daniel created this task.Sep 30 2019, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2019, 3:08 PM

Change 533734 had a related patch set uploaded (by Daniel Kinzler; owner: simetrical):
[mediawiki/core@master] Unit tests for DBFileJournal

https://gerrit.wikimedia.org/r/533734

daniel triaged this task as Medium priority.Sep 30 2019, 4:30 PM

Change 533734 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Unit tests for DBFileJournal

https://gerrit.wikimedia.org/r/533734

Coverage for includes/filebackend/: 41.18% of lines (119/289)

Coverage for includes/libs/filebackend/: 52.24% of lines (1726/3304)

Doing libs/filebackend/ is a bit of a longer-term project.

Change 545783 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Hard-deprecate LockManagerGroup::getDefault/getAny

https://gerrit.wikimedia.org/r/545783

Coverage for includes/libs/lockmanager: 16.64% of lines (116/697)

For some reason we have includes/filebackend/lockmanager, but includes/libs/lockmanager not under filebackend.

Change 546359 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Unit test for MySqlLockManager

https://gerrit.wikimedia.org/r/546359

Change 547006 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Unit tests for FileBackend

https://gerrit.wikimedia.org/r/547006

Change 547006 merged by jenkins-bot:
[mediawiki/core@master] Unit tests for FileBackend

https://gerrit.wikimedia.org/r/547006

Change 547173 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] 100% unit test coverage for FileBackend

https://gerrit.wikimedia.org/r/547173

Change 545783 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate LockManagerGroup::getDefault/getAny

https://gerrit.wikimedia.org/r/545783

Change 547173 merged by jenkins-bot:
[mediawiki/core@master] 100% unit test coverage for FileBackend

https://gerrit.wikimedia.org/r/547173

Change 546359 merged by jenkins-bot:
[mediawiki/core@master] Unit test for MySqlLockManager

https://gerrit.wikimedia.org/r/546359