Page MenuHomePhabricator
Create Task
Maniphest T234311

Fix and restore daily browser tests for TwoColConflict
Closed, ResolvedPublic
Actions

Description

In T232608: Delete selenium-daily-beta-EXTENSION Jenkins jobs that are broken more than 30 days the daily browser tests for TwoColConflict are being reported as broken, and the job being deleted after 30 days. Before going default with the extension we need to restore this safety net.

Acceptance criteria:

  • We understand what failed and fixed it
  • The test run once a day
  • Failing tests send an email to techwish-devs@wikimedia.de

Link to job: https://integration.wikimedia.org/ci/job/selenium-daily-beta-TwoColConflict/

Foes vanquished:

  • patch Use wdio-mediawiki public API rather than peeking at internal files using relative paths.
  • patch Temporarily hide the beta features "save" bar, it has problematic floating behavior and obscures UI elements.
  • patch Disable "2017 wikitext source editor", this doesn't provide a simple ES interface to let us set content.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Prevent VisualEditormediawiki/extensions/TwoColConflictmaster+5 -2
[WIP] set edit box content for VEmediawiki/extensions/TwoColConflictmaster+1 -1
Hide the floating save-barmediawiki/extensions/TwoColConflictmaster+13 -2
Scroll beta preference into viewmediawiki/extensions/TwoColConflictmaster+1 -0
Reenable TwoColConflict browser testsintegration/configmaster+4 -0
Use wdio-mediawiki core wrappersmediawiki/extensions/TwoColConflictmaster+481 -364
Fix browser testmediawiki/extensions/TwoColConflictmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Oct 1 2019, 10:04 AM
zeljkofilipin added projects: User-zeljkofilipin, Release-Engineering-Team-TODO (201910), Release-Engineering-Team (Unit & Int & System Tooling).Oct 1 2019, 10:48 AM
zeljkofilipin moved this task from Backlog 🪒 to Quarter 👔 on the User-zeljkofilipin board.
zeljkofilipin moved this task from INBOX to Ready on the Release-Engineering-Team-TODO (201910) board.
zeljkofilipin subscribed.Oct 1 2019, 10:51 AM

Let me know when you're ready to work on fixing the tests. I can restore the job and configure it to send failure mails to techwish-devs@wikimedia.de.

gerritbot added a comment.Oct 1 2019, 10:58 AM

Change 540097 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Fix browser test

https://gerrit.wikimedia.org/r/540097

gerritbot added a project: Patch-For-Review.Oct 1 2019, 10:58 AM
gerritbot added a comment.Oct 1 2019, 11:01 AM

Change 540098 had a related patch set uploaded (by Awight; owner: Awight):
[integration/config@master] Reenable TwoColConflict browser tests

https://gerrit.wikimedia.org/r/540098

awight added a project: WMDE-QWERTY-Sprint-2019-09-25.Oct 1 2019, 11:02 AM
awight moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-09-25 board.
gerritbot added a comment.Oct 1 2019, 12:00 PM

Change 540105 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Use wdio-mediawiki core wrappers

https://gerrit.wikimedia.org/r/540105

gerritbot added a comment.Oct 1 2019, 12:01 PM

Change 540097 abandoned by Awight:
Fix browser test

https://gerrit.wikimedia.org/r/540097

awight claimed this task.Oct 1 2019, 1:19 PM
gerritbot added a comment.Oct 2 2019, 10:55 AM

Change 540105 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Use wdio-mediawiki core wrappers

https://gerrit.wikimedia.org/r/540105

zeljkofilipin moved this task from Quarter 👔 to Deep work 🌊 on the User-zeljkofilipin board.Oct 2 2019, 1:02 PM
zeljkofilipin moved this task from Ready to Doing on the Release-Engineering-Team-TODO (201910) board.
zeljkofilipin triaged this task as Medium priority.Oct 2 2019, 1:57 PM
zeljkofilipin added a comment.Oct 2 2019, 2:11 PM

We understand what failed and fixed it

According to T199113, the problem was:

selenium-daily-beta-TwoColConflict fails with ERROR: Cannot find module '../../../../../tests/selenium/pageobjects/edit.page'

It was probably fixed here:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/540105/5/tests/selenium/pageobjects/editconflict.page.js

gerritbot added a comment.Oct 2 2019, 2:44 PM

Change 540098 merged by jenkins-bot:
[integration/config@master] Reenable TwoColConflict browser tests

https://gerrit.wikimedia.org/r/540098

zeljkofilipin added a comment.Oct 2 2019, 2:46 PM

selenium-daily-beta-TwoColConflict job is deployed.

It is failing:

...
+ npm run-script selenium-daily
...
Number of specs: 5


0 passing (57.80s)
5 failing
...

Instructions on how to target beta cluster (as the job does) is available at Selenium/Node.js/Target beta cluster.

Let me know if you have any questions or need help fixing the failures.

zeljkofilipin moved this task from Doing to Done (within RelEng) on the Release-Engineering-Team-TODO (201910) board.Oct 2 2019, 2:46 PM
zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.
Maintenance_bot removed a project: Patch-For-Review.Oct 2 2019, 3:10 PM
gerritbot added a comment.Oct 2 2019, 3:27 PM

Change 540425 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Scroll beta preference into view

https://gerrit.wikimedia.org/r/540425

gerritbot added a project: Patch-For-Review.Oct 2 2019, 3:27 PM
awight added a comment.Oct 4 2019, 7:43 AM

This might be fixed once we merge:

thiemowmde added a comment.Oct 4 2019, 7:48 AM

https://gerrit.wikimedia.org/r/540425 is the only patch open here. It seems it fails because it uses a Webdriverio version 5 feature, but we aren't on version 5 yet. @zeljkofilipin, is there a backwards-compatible method we can use instead of scrollIntoView? Or are we able to update to version 5 within the next days?

awight added a comment.EditedOct 4 2019, 7:50 AM
In T234311#5546176, @thiemowmde wrote:

https://gerrit.wikimedia.org/r/540425 is the only patch open here. It seems it fails because it uses a Webdriverio version 5 feature, but we aren't on version 5 yet. @zeljkofilipin, is there a backwards-compatible method we can use instead of scrollIntoView? Or are we able to update to version 5 within the next days?

I don't think this is quite right. scrollIntoView is well-supported by browsers: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView . Maybe I need to wrap my code in browser.execute, but I think it actually works as I've written it, since I'm running wdio 4 and it passes for me.

awight added a comment.Oct 4 2019, 9:05 AM

There was a wdio 4 function after all, patch has been updated.
http://v4.webdriver.io/api/protocol/moveTo.html

zeljkofilipin moved this task from Done (within RelEng) to Doing on the Release-Engineering-Team-TODO (201910) board.Oct 4 2019, 10:22 AM
zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.
awight added a comment.Oct 4 2019, 11:30 AM

Ready for final review.

gerritbot added a comment.Oct 4 2019, 1:02 PM

Change 540425 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Scroll beta preference into view

https://gerrit.wikimedia.org/r/540425

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2019, 1:10 PM
zeljkofilipin added a comment.Oct 4 2019, 1:24 PM

selenium-daily-beta-TwoColConflict is still failing, now with TwoColConflict "before all" hook: invalidjson: No valid JSON response

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 4 2019, 2:00 PM
gerritbot added a comment.Oct 7 2019, 8:11 AM

Change 541197 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Hide the floating save-bar

https://gerrit.wikimedia.org/r/541197

gerritbot added a project: Patch-For-Review.Oct 7 2019, 8:11 AM
gerritbot added a comment.Oct 7 2019, 9:25 AM

Change 541197 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Hide the floating save-bar

https://gerrit.wikimedia.org/r/541197

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2019, 10:10 AM
awight moved this task from Review to Doing on the WMDE-QWERTY-Sprint-2019-09-25 board.Oct 7 2019, 10:19 AM
gerritbot added a comment.Oct 7 2019, 1:43 PM

Change 541255 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] [WIP] set edit box content for VE

https://gerrit.wikimedia.org/r/541255

gerritbot added a project: Patch-For-Review.Oct 7 2019, 1:43 PM

Change 541256 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] [WIP] Set content under VE

https://gerrit.wikimedia.org/r/541256

zeljkofilipin moved this task from Doing to Done (within RelEng) on the Release-Engineering-Team-TODO (201910) board.Oct 7 2019, 2:32 PM
zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.
gerritbot added a comment.Oct 7 2019, 4:31 PM

Change 541255 abandoned by Awight:
[WIP] set edit box content for VE

https://gerrit.wikimedia.org/r/541255

awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-09-25 board.Oct 7 2019, 4:32 PM
awight moved this task from Review to Doing on the WMDE-QWERTY-Sprint-2019-09-25 board.Oct 7 2019, 9:46 PM
awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-09-25 board.Oct 9 2019, 11:59 AM
awight updated the task description. (Show Details)Oct 9 2019, 12:04 PM
gerritbot added a comment.Oct 9 2019, 12:37 PM

Change 541256 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Prevent VisualEditor

https://gerrit.wikimedia.org/r/541256

awight moved this task from Review to Done on the WMDE-QWERTY-Sprint-2019-09-25 board.Oct 9 2019, 12:58 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.2; 2019-10-15); removed MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 9 2019, 1:00 PM
awight updated the task description. (Show Details)Oct 9 2019, 1:09 PM
awight removed a project: Patch-For-Review.
thiemowmde closed this task as Resolved.Oct 9 2019, 2:09 PM
awight mentioned this in rESCC572e93c9cec2: Prevent VisualEditor.Oct 9 2019, 10:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits