Page MenuHomePhabricator

Upgrade webdriverio to version 5 for all repositories
Open, MediumPublic

Description

CodeSearch: "webdriverio": ".?4 AND file=package.json

  • mediawiki/core T213268
  • mediawiki/extensions/AbuseFilter
  • mediawiki/extensions/AdvancedSearch
  • mediawiki/extensions/CirrusSearch:
    • tests/integration
    • tests/selenium
  • mediawiki/extensions/Cite
  • mediawiki/extensions/ContentTranslation
  • mediawiki/extensions/Echo
  • mediawiki/extensions/ElectronPdfService
  • mediawiki/extensions/FileImporter
  • mediawiki/extensions/GrowthExperiments
  • mediawiki/extensions/Math
  • mediawiki/extensions/MobileFrontend
  • mediawiki/extensions/Newsletter
  • mediawiki/extensions/ORES
  • mediawiki/extensions/Popups
  • mediawiki/extensions/RelatedArticles
  • mediawiki/extensions/RevisionSlider
  • mediawiki/extensions/TemplateWizard
  • mediawiki/extensions/TwoColConflict
  • mediawiki/extensions/Wikibase
  • mediawiki/extensions/WikibaseCirrusSearch
  • mediawiki/extensions/WikibaseLexeme
  • mediawiki/extensions/WikibaseMediaInfo
  • mediawiki/skins/MinervaNeue
  • phab-deployment
  • wikibase/termbox
  • wikidata/query/gui
  • wikimedia/portals/deploy

Details

Related Gerrit Patches:
mediawiki/extensions/GrowthExperiments : masterselenium: Upgrade from webdriverio v4 to v5
mediawiki/extensions/TwoColConflict : masterUpdate to wdio 5
wikidata/query/gui : masterMigrate to WebdriverIO v5

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptOct 1 2019, 10:33 AM
zeljkofilipin triaged this task as Medium priority.Oct 1 2019, 10:33 AM
Krinkle added a subscriber: Krinkle.Oct 1 2019, 4:11 PM

This should probably wait for T234002 to settle first so that we can push a new wdio-mediawiki package after that, which will make the migration easier for other repos, so that they can adopt v5 and make other minor changes related to improved practices for how tests are written, which will go together in the next release of that package.

Right now, for an extension to migrate directly to wdio 5 would require temporarily migrating away from wdio-mediawiki.

zeljkofilipin changed the task status from Open to Stalled.Oct 2 2019, 10:57 AM

Blocked on T234002.

@Krinkle Thanks for the warning, I've assumed wdio-mediawiki was updated, I obviously didn't check. ๐Ÿคฆโ€โ™‚๏ธ

โ€ข hashar added a subscriber: โ€ข hashar.

I have added a codesearch link to the task description: https://codesearch.wmflabs.org/things/?q="webdriverio"%3A ".%3F4&files=package.json

zeljkofilipin added a subscriber: โ€ข hashar.

Thanks @hashar! Looks like I've missed ContentTranslation!

Change 542462 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Migrate to WebdriverIO v5

https://gerrit.wikimedia.org/r/542462

Restricted Application added a subscriber: Masumrezarock100. ยท View Herald TranscriptOct 11 2019, 4:58 PM

Change 542462 merged by jenkins-bot:
[wikidata/query/gui@master] Migrate to WebdriverIO v5

https://gerrit.wikimedia.org/r/542462

Addshore updated the task description. (Show Details)Oct 31 2019, 6:48 AM

Change 540104 had a related patch set uploaded (by Zfilipin; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Update to wdio 5

https://gerrit.wikimedia.org/r/540104

zeljkofilipin changed the task status from Stalled to Open.Nov 7 2019, 3:40 PM

T236927 is resolved, no longer stalled.

Krinkle removed a subscriber: Krinkle.Nov 8 2019, 12:55 AM

Change 556810 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/GrowthExperiments@master] selenium: Upgrade from webdriver v4 to v5

https://gerrit.wikimedia.org/r/556810

Change 556810 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/GrowthExperiments@master] selenium: Upgrade from webdriver v4 to v5
https://gerrit.wikimedia.org/r/556810

Looks like the patch to upgrade webdriverio failed for GrowthExperiments (and TemplateWizard locally when I tried making a patch to upgrade). I noticed that they both seem to fail in similar ways. The error reads "UnhandledPromiseRejectionWarning: TypeError: adminBot.getCreateaccountToken is not a function" for GrowthExperiments and "UnhandledPromiseRejectionWarning: TypeError: Api.edit is not a function" for TemplateWizard.