Page MenuHomePhabricator
Create Task
Maniphest T234339

Some parser errors are not reported by the syntax check
Closed, ResolvedPublic
Actions

Description

Going to Special:AbuseFilter/tools and running a "check syntax" on the following snippet:

accountname rlike "("

results in no error, but the regexp is obviously wrong. I suspect this happens because the regex is validated when the LHS is not DUNDEFINED, and accountname in this case is.

Update: This happens for invalid regexps (in (i)rlike and rcount), and invalid IP ranges passed to ip_in_range

Details

SubjectRepoBranchLines +/-
Better handling of keywords and functionsmediawiki/extensions/AbuseFiltermaster+52 -5
Make to sure to report division by zero when the LHS is undefinedmediawiki/extensions/AbuseFiltermaster+15 -4
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Oct 1 2019, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2019, 3:38 PM
Daimona claimed this task.Oct 1 2019, 3:38 PM
Daimona triaged this task as High priority.
gerritbot added a comment.Oct 1 2019, 4:30 PM

Change 540165 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Better handling of keywords and functions

https://gerrit.wikimedia.org/r/540165

gerritbot added a project: Patch-For-Review.Oct 1 2019, 4:30 PM
Daimona renamed this task from Regex error not reported by the syntax check to Some parser errors are not reported by the syntax check.Oct 1 2019, 4:36 PM
Daimona updated the task description. (Show Details)
Krinkle subscribed.Oct 1 2019, 4:46 PM

To confirm - did these ever work in recent history? Presumably these fail unconditionally in a way that filter is effectively disabled / never matches. Is that correct?

Daimona added a comment.Oct 1 2019, 4:47 PM

They stopped working as of the DUNDEFINED update that happened a while ago. Those filters error out and never match, yes.

Daimona mentioned this in T237459: Internal error from modulo by float-y zero.Nov 7 2019, 4:27 PM
gerritbot added a comment.Nov 7 2019, 4:37 PM

Change 549567 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Make to sure to report division by zero when the LHS is undefined

https://gerrit.wikimedia.org/r/549567

gerritbot added a comment.Nov 8 2019, 6:05 PM

Change 540165 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Better handling of keywords and functions

https://gerrit.wikimedia.org/r/540165

gerritbot added a comment.Nov 8 2019, 6:05 PM

Change 549567 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Make to sure to report division by zero when the LHS is undefined

https://gerrit.wikimedia.org/r/549567

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2019, 6:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 8 2019, 7:00 PM
Daimona closed this task as Resolved.Nov 8 2019, 7:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL