| EMartin | |
| Oct 1 2019, 4:10 PM |
| F30518294: image.png | |
| Oct 1 2019, 4:10 PM |
| F30518296: image.png | |
| Oct 1 2019, 4:10 PM |
This issue was experienced during the India market test. Dlocal has indicated that this occurred while the donor was on the Wiki page, therefore suggesting that our validation routine may need some review:
One other new issue: one donor got a validation error from the form for what looks like a proper PAN:
614787.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Better PAN validation for India | mediawiki/extensions/DonationInterface | master | +27 -15 |
Change 569294 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Better PAN validation for India
Weird - the original donor should have gotten through based on the current rules, which just look for a 10 character string.
That patch actually tightens up the rules to only allow PANs that match the specific pattern of letters and numbers that are valid.
We could maybe add logging around failed validations if we see more.
@Cstone So besides Zendesk #614787, the only other PAN error I could find is #600164. This was from August 28th, and the donor said:
As requested i was trying to donate but the site is asking to correct my PAN details but there is no option to correct it.
This donor is cid=1662380 and it looks like they donated September 1st, 2019 as ID: ASTROPAY 184570286, Invoice Reference: 69044223.1 and also more recently on February 11th as ID: ASTROPAY 219399617 Invoice Reference: 79136896.1
@Cstone I feel like it might help to know which browsers people are using and which specific values (trailing / leading space?) are causing the issue. So when we show the error, we could also make a call to the logPaymentsFormError API method like we do on catching a JS error: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/modules/js/ext.donationInterface.errorLog.js
@EMartin In the last India test, you had mentioned that there were a lot of donation issues related to the PAN bug here. DS doesn't have many on file. How did you determine there were PAN issues in the last test?
Hi David, we did not see PAN issues in the latest tests. This Phab tas was
opened last year in initial tests. We did not see this PAN issue in the
last two recent tests.
What we have seen a lot of consistently is donors asking why the PAN is necessary, maybe that's what you were picking up on, @DStrine ?
@DStrine. I believe we can close this task. There is no issue with PAN at the present time. As Michael B. reports, there is a general objection related to providing the PAN which we can't do anything about, but this task, as entered above, has not recurred in the latest 2020 tests.
Ok thanks for all the info! I will take this out of the sprint for now. If this does not happen again in the test next week, I will close it.
Change 569294 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Better PAN validation for India