Ensure users can navigate image cards via keyboard
Closed, ResolvedPublic
Actions

Description

Currently, with OOUI tabs behavior, focus on image cards lands on the "skip" link as this is the first non-disabled link. We need to change tag elements to be focusable items so users can tab through them before hitting the action links.

QA Results

AC	Status	Details
1	✅	T234357#5686149

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MachineVision	master	+167 -180	Enable keyboard navigation and refactor to single SuggestionWidget

Customize query in gerrit

Event Timeline

AnneT created this task.Oct 1 2019, 6:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2019, 6:15 PM

• Mholloway moved this task from Backlog to In development on the MachineVision board.Oct 2 2019, 5:17 PM

Change 540480 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Enable keyboard navigation and refactor to single SuggestionWidget

https://gerrit.wikimedia.org/r/540480

gerritbot added a project: Patch-For-Review.Oct 2 2019, 8:29 PM

AnneT moved this task from Triage to Current Work on the Structured-Data-Backlog board.Oct 3 2019, 3:34 PM

AnneT edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

AnneT moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Oct 7 2019, 4:47 PM

Change 540480 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Enable keyboard navigation and refactor to single SuggestionWidget

https://gerrit.wikimedia.org/r/540480

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 7 2019, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2019, 8:10 PM

AnneT moved this task from In development to Done on the MachineVision board.Oct 15 2019, 8:51 PM

AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 17 2019, 10:18 PM

• Ramsey-WMF reassigned this task from AnneT to Edtadros.Nov 14 2019, 11:50 PM

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP

Test Artifact(s):
✅ AC1: Tag elements should be focusable so users can tab through them.

Suggested tags - Test Wikimedia Commons.gif (780×573 px, 276 KB)

Edtadros updated the task description. (Show Details)Nov 23 2019, 1:34 AM

• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Nov 25 2019, 5:20 PM

Tested on production. Tab order starts with the links at the beginning of the page and goes to the tags (which can be selected with a tap of the Enter key)

	F31141712: Suggested tags - Test Wikimedia Commons.gif
	Nov 23 2019, 1:33 AM

Ensure users can navigate image cards via keyboardClosed, ResolvedPublicActions