UserBlockedError passes the global request context to the block methods that format errors.
We can improve on this:
We should make these improvements after the block formatter service is introduced in T227174.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Allow user, language and IP to be passed to UserBlockedError | mediawiki/core | master | +65 -15 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Tchanders | T234406 Pass the relevant and necessary context information to UserBlockedError | |||
| Resolved | Tchanders | T227174 Improve the consistency of block error notices |
Change 538452 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Allow user, language and IP to be passed to UserBlockedError
Change 538452 merged by jenkins-bot:
[mediawiki/core@master] Allow user, language and IP to be passed to UserBlockedError
As part of T227007#5598774 I tested how block error messages look in most of the places in the code that we changed, including in different languages. Missing, I think, SpecialRevisionDelete and SpecialUserrights.
I have briefly tested SpecialRevisionDelete and SpecialUserrights on test as an admin with a database block on my user.