Page MenuHomePhabricator

Error when searching for exact phrase on English Wikipedia: "Precondition failed: Must have a resultset set"
Closed, ResolvedPublic

Description

When I search for an exact phrase on the English Wikipedia, while using Chrome browser (but not Firefox), I receive this error:

Internal error - [XZS4IgpAAEQAAAoljdUAAACR] 2019-10-02 14:45:54: Fatal exception of type "Wikimedia\Assert\PreconditionException"

For example, when I searched for "National Center for PTSD" I received the above message (URL of results page = https://en.wikipedia.org/w/index.php?cirrusUserTesting=glent_m0&search=%22National+Center+for+PTSD%22&title=Special:Search&go=Go )

I'm on a Win 10 desktop (64-bit; updated regularly; Malwarebytes; Kaspersky Total Security).
Chrome Version 77.0.3865.90 (Official Build) (64-bit).
Firefox 69.0.1 (64-bit)

My technical know-how is very limited. I apologize in advance if this is not the best way to report this anomaly. Thanks! - Mark

Details

Request ID
XZS4IgpAAEQAAAoljdUAAACR
Stack Trace

#0 /srv/mediawiki/php-1.34.0-wmf.24/extensions/CirrusSearch/includes/Fallbacks/FallbackRunnerContextImpl.php(105): Wikimedia\Assert\Assert::precondition(boolean, string)
#1 /srv/mediawiki/php-1.34.0-wmf.24/extensions/CirrusSearch/includes/Fallbacks/IndexLookupFallbackMethod.php(166): CirrusSearch\Fallbacks\FallbackRunnerContextImpl->getMethodResponse()
#2 /srv/mediawiki/php-1.34.0-wmf.24/extensions/CirrusSearch/includes/Fallbacks/FallbackRunner.php(119): CirrusSearch\Fallbacks\IndexLookupFallbackMethod->successApproximation(CirrusSearch\Fallbacks\FallbackRunnerContextImpl)
#3 /srv/mediawiki/php-1.34.0-wmf.24/extensions/CirrusSearch/includes/Searcher.php(364): CirrusSearch\Fallbacks\FallbackRunner->run(CirrusSearch\Searcher, CirrusSearch\Search\ResultSet, CirrusSearch\Search\MSearchResponses, class@anonymous

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Oct 2, 3:02 PM
Aklapper changed the subtype of this task from "Task" to "Production Error".
Restricted Application added a project: Discovery-Search. · View Herald TranscriptWed, Oct 2, 5:43 PM
Aklapper renamed this task from Error - exact phrase search - Wikipedia - Chrome browser only to Error when searching for exact phrase on English Wikipedia: "Precondition failed: Must have a resultset set".Wed, Oct 2, 5:45 PM
Aklapper set Request ID to XZS4IgpAAEQAAAoljdUAAACR.
Aklapper edited Stack Trace. (Show Details)
dcausse triaged this task as High priority.Wed, Oct 2, 6:45 PM
dcausse added a subscriber: dcausse.

Thanks for the report, there is indeed a problem in the software that is causing this anomaly.

Change 540461 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Fix Precondition failed: Must have a resultset set

https://gerrit.wikimedia.org/r/540461

dcausse claimed this task.Wed, Oct 2, 6:47 PM
dcausse moved this task from in progress to Needs review on the Discovery-Search (Current work) board.

Change 540461 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Fix Precondition failed: Must have a resultset set

https://gerrit.wikimedia.org/r/540461

Just wanted to jump in and say "Thank you!" for responding so incredibly fast. Y'all are fabulous! All the best ~ Mark

Change 540494 had a related patch set uploaded (by EBernhardson; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.25] Fix Precondition failed: Must have a resultset set

https://gerrit.wikimedia.org/r/540494

Change 540495 had a related patch set uploaded (by EBernhardson; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.24] Fix Precondition failed: Must have a resultset set

https://gerrit.wikimedia.org/r/540495

Change 540495 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.24] Fix Precondition failed: Must have a resultset set

https://gerrit.wikimedia.org/r/540495

Change 540494 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.25] Fix Precondition failed: Must have a resultset set

https://gerrit.wikimedia.org/r/540494

Mentioned in SAL (#wikimedia-operations) [2019-10-02T23:21:21Z] <ebernhardson@deploy1001> Synchronized php-1.34.0-wmf.25/extensions/CirrusSearch/: T234445: CirrusSearch: Fix Precondition failed: Must have a resultset set (duration: 01m 02s)

Mentioned in SAL (#wikimedia-operations) [2019-10-02T23:22:30Z] <ebernhardson@deploy1001> Synchronized php-1.34.0-wmf.24/extensions/CirrusSearch/: T234445: CirrusSearch: Fix Precondition failed: Must have a resultset set (duration: 01m 00s)

dcausse closed this task as Resolved.Mon, Oct 7, 10:03 AM