Reproduce:
- https://meta.wikimedia.org/wiki/Special:Contributions
- Type "A" into "IP address or username"
Expected:
A list of usernames shown (compare Special:CentralAuth)
Actual:
No autocomplete.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Special:Contributions: Fix user target autocomplete | mediawiki/core | master | +1 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
| Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
| Open | None | T100161 Convert all of MediaWiki core to OOUI PHP (tracking) | |||
| Open | None | T107037 Convert all MW core special pages to OOUI | |||
| Resolved | Ladsgroup | T219238 Remove SpecialContributions::getForm::filters hook call | |||
| Resolved | Jdlrobson | T117736 Convert Special:Contributions to OOUI | |||
| Resolved | Jayprakash12345 | T234510 autocomplete in Special:Contributions no longer works |
Event Timeline
Comment Actions
Looks like the field has the mw-autocomplete-user class for the mediawiki.userSuggest module but instead should just use HTMLGlobalUserTextField::class as the class instead of the type being text (and drop the dependency on mediawiki.userSuggest).
Comment Actions
Change 540969 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/core@master] Fix Autocomplete in Special:Contributions
Comment Actions
I think we should not use HTMLGlobalUserTextField::class as it is a part of CentralAuth Extension. It will create the MediaWiki core dependency to CentralAuth Extension. The simple solution is here is that use type => user. This HTMLForm widget uses mw-autocomplete-user.
Comment Actions
Change 540969 merged by jenkins-bot:
[mediawiki/core@master] Special:Contributions: Fix user target autocomplete
Comment Actions
User-notice ? Sort of: "previously, Special:Contributions had an autocomplete functionality that was lost during the transition to the new OOUI design. This functionality has been restored"?