Page MenuHomePhabricator
Create Task
Maniphest T234581

Deprecate and remove the 'jquery.tabIndex' module from core
Closed, ResolvedPublic
Actions

Description

Was developed for the Vector skin long ago.

No longer used as of https://gerrit.wikimedia.org/r/540733 (T226148)

Details

SubjectRepoBranchLines +/-
Remove jquery.tabIndex modulemediawiki/coremaster+2 -62
Deprecate 'jquery.tabIndex' modulemediawiki/coremaster+2 -37
Deprecate 'jquery.tabIndex' modulemediawiki/coreREL1_34+2 -37
Remove use of 'jquery.tabIndex'mediawiki/skins/Timelessmaster+0 -8
Remove use of jquery.tabIndex (take 2)mediawiki/extensions/WikiEditormaster+0 -23
Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.jsmediawiki/extensions/WikiEditormaster+0 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Oct 4 2019, 12:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2019, 12:09 AM
Krinkle edited projects, added MediaWiki-User-Interface; removed MediaWiki-Interwiki.Oct 4 2019, 12:09 AM
Krinkle moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
Krinkle added a parent task: T233676: Audit default module payload (2019).Oct 8 2019, 3:44 AM
gerritbot added a comment.Oct 11 2019, 9:53 PM

Change 542607 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikiEditor@master] Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js

https://gerrit.wikimedia.org/r/542607

gerritbot added a project: Patch-For-Review.Oct 11 2019, 9:53 PM
Krinkle added a project: Accessibility.Oct 11 2019, 10:41 PM
gerritbot added a comment.Oct 11 2019, 10:42 PM

Change 542615 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/skins/Timeless@master] Remove use of 'jquery.tabIndex' in favour of hardcoded high int

https://gerrit.wikimedia.org/r/542615

Krinkle triaged this task as Medium priority.Oct 11 2019, 10:43 PM
Krinkle added a project: MW-1.35-release.
Krinkle moved this task from Blocker to To deprecate or remove on the MW-1.35-release board.
gerritbot added a comment.Oct 12 2019, 2:13 AM

Change 542607 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js

https://gerrit.wikimedia.org/r/542607

Krinkle removed a project: Patch-For-Review.Oct 12 2019, 2:19 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 12 2019, 3:00 AM
Ammarpad claimed this task.Oct 13 2019, 5:13 AM
gerritbot added a comment.Oct 13 2019, 10:44 AM

Change 542751 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate 'jquery.tabIndex' module

https://gerrit.wikimedia.org/r/542751

gerritbot added a project: Patch-For-Review.Oct 13 2019, 10:44 AM
gerritbot added a comment.Oct 16 2019, 9:00 PM

Change 543695 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikiEditor@master] Remove more setTabindexes() calls

https://gerrit.wikimedia.org/r/543695

gerritbot added a comment.Oct 16 2019, 9:49 PM

Change 543695 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove use of jquery.tabIndex (take 2)

https://gerrit.wikimedia.org/r/543695

gerritbot added a comment.Oct 17 2019, 4:26 PM

Change 542615 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Remove use of 'jquery.tabIndex'

https://gerrit.wikimedia.org/r/542615

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.3; 2019-10-22); removed MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 17 2019, 8:00 PM
gerritbot added a comment.Oct 18 2019, 11:49 PM

Change 544273 had a related patch set uploaded (by Krinkle; owner: Ammarpad):
[mediawiki/core@REL1_34] Deprecate 'jquery.tabIndex' module

https://gerrit.wikimedia.org/r/544273

gerritbot added a comment.Oct 18 2019, 11:58 PM

Change 544273 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate 'jquery.tabIndex' module

https://gerrit.wikimedia.org/r/544273

ReleaseTaggerBot added a project: MW-1.34-notes.Oct 19 2019, 12:00 AM
gerritbot added a comment.Oct 19 2019, 12:01 AM

Change 542751 merged by jenkins-bot:
[mediawiki/core@master] Deprecate 'jquery.tabIndex' module

https://gerrit.wikimedia.org/r/542751

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2019, 12:10 AM
Krinkle removed projects: MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 25 2019, 8:12 PM

Next step: Remove the module.

Krinkle added a comment.EditedOct 25 2019, 8:12 PM

@Ammarpad Want to give that a go as well?

Krinkle updated the task description. (Show Details)Oct 25 2019, 8:14 PM
Krinkle updated the task description. (Show Details)EditedOct 26 2019, 12:15 AM

Ticking the box for "Analyse gadgets, site scripts, and user scripts".

I found only 1 use in all User, Project and MediaWiki namespace pages on the public WMF wikis, which was enwiki:User:/portlet-toggle.js. I have fixed this script. There are no further uses of the module or its functions (Global search).

In any event, I've written a migration guide for third parties as well:

https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users)#jquery.tabIndex

Krinkle updated the task description. (Show Details)Oct 26 2019, 12:19 AM
Ammarpad added a comment.Oct 26 2019, 11:58 AM
In T234581#5607477, @Krinkle wrote:

@Ammarpad Want to give that a go as well?

Yes, sure. So we're to remove it altogether now? I thought the deprecation and removal are staggered between different releases.

Ammarpad added a comment.EditedOct 26 2019, 12:35 PM

Never mind my above comment, I now notice the removal will be in *1.35*

Krinkle added a comment.Oct 26 2019, 4:03 PM

Yeah, 1.34 will be released soon from the REL1_34 branch. 1.35 will be released next year, but the master branch is already developing for 1.35 so this can start now :)

gerritbot added a comment.Oct 27 2019, 12:46 AM

Change 546349 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove jquery.tabIndex module

https://gerrit.wikimedia.org/r/546349

gerritbot added a project: Patch-For-Review.Oct 27 2019, 12:46 AM
Ammarpad awarded a token.Oct 27 2019, 1:02 AM
Krinkle closed this task as Resolved.Nov 8 2019, 5:57 PM
Krinkle removed a project: Patch-For-Review.
Krinkle updated the task description. (Show Details)
gerritbot added a comment.Nov 8 2019, 6:10 PM

Change 546349 merged by jenkins-bot:
[mediawiki/core@master] Remove jquery.tabIndex module

https://gerrit.wikimedia.org/r/546349

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 8 2019, 7:00 PM
Umherirrender mentioned this in T241332: Remove or replace usage of deprecated jquery.tabIndex in extensions.Dec 22 2019, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL