Page MenuHomePhabricator

Enqueue: Don't allow enqueueing a page already in the queue
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Find a page that is in the new pages feed, or add a page to the feed
  • Try to add the page to the feed again

Expected result:
Error, the page is already in the queue

Actual result:
Request is processed, new log entries added, user is told the result was successful

Details

Related Gerrit Patches:
mediawiki/extensions/PageTriage : masterEnqueue: Don't allow enqueueing pages already in the queue

Event Timeline

DannyS712 created this task.Oct 4 2019, 2:58 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 4 2019, 2:58 AM

Change 540749 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Enqueue: Don't allow enqueueing pages already in the queue

https://gerrit.wikimedia.org/r/540749

Change 540749 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Enqueue: Don't allow enqueueing pages already in the queue

https://gerrit.wikimedia.org/r/540749

Good stuff! Probably could use QA.

Using the API, I cannot requeue pages in the Article, User or Draft namespaces that are already in the queue.

I see the error: The page specified already exists in the pagetriage queue.

This change should not have a user-facing impact (unless the user also uses the API). It does not affect the UI.

I tested this on beta, but I believe it should be on production now.

DannyS712 added a comment.EditedFri, Nov 1, 1:29 AM
Api error
{
    "error": {
        "code": "bad-pagetriage-enqueue-alreadyqueued",
        "info": "The page specified already exists in the pagetriage queue",
        "*": "See https://en.wikipedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
    },
    "servedby": "mw1343"
}

confirmed to be working

ifried closed this task as Resolved.Fri, Nov 1, 5:21 PM
ifried moved this task from Product sign-off to Done on the Community-Tech (Kanban-Q2-2019-20) board.

@DannyS712 Thank you! I will mark this work as Done.