Page MenuHomePhabricator
Create Task
Maniphest T234602

Fade-out effect in scrolling reference popups sometimes overlaps scrollbars
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The fadeout effect behaves a little odd when both scrollbars are present. When I scroll to the very right, the fadeout overlaps the horizontal scrollbar. As far as I remember, the requirement was that the fadeout does not overlap this scrollbar.

Screenshot from 2019-09-20 10-04-16.png (377×195 px, 23 KB)

This does not happen when the content is not scrolled to the very right.

Screenshot from 2019-09-20 10-04-11.png (365×196 px, 23 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix code detecting horizontal scrollbar in reference previewsThiemo Kreuz (WMDE)mediawiki/extensions/Popupsmaster+12 -10
Customize query in gerrit

Event Timeline

thiemowmde created this task.Oct 4 2019, 8:13 AM
gerritbot added a comment.Oct 4 2019, 8:29 AM

Change 540806 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix code detecting horizontal scrollbar in reference previews

https://gerrit.wikimedia.org/r/540806

gerritbot added a project: Patch-For-Review.Oct 4 2019, 8:29 AM
thiemowmde claimed this task.Oct 4 2019, 8:59 AM
thiemowmde added a project: WMDE-QWERTY-Sprint-2019-09-25.
thiemowmde set the point value for this task to 1.
thiemowmde moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-09-25 board.
gerritbot added a comment.Oct 9 2019, 1:50 PM

Change 540806 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix code detecting horizontal scrollbar in reference previews

https://gerrit.wikimedia.org/r/540806

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 9 2019, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 9 2019, 2:10 PM
thiemowmde closed this task as Resolved.Oct 9 2019, 2:15 PM
Lena_WMDE moved this task from Backlog to Doing on the Reference Previews board.May 31 2021, 8:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits