Page MenuHomePhabricator

Wikimedia Technical Conference 2019 Session: Code Health/Code Review
Open, Needs TriagePublic

Subscribers
Tokens
"Love" token, awarded by Tgr."Meh!" token, awarded by zeljkofilipin."Like" token, awarded by brennen."Evil Spooky Haunted Tree" token, awarded by Addshore."Like" token, awarded by MusikAnimal."Like" token, awarded by Jrbranaa."Like" token, awarded by Aklapper."Love" token, awarded by hashar."Like" token, awarded by Nikerabbit."Like" token, awarded by kostajh.
Assigned To
Authored By
debt, Fri, Oct 4

Description

Session

  • Track: People and Processes
  • Topic: Code Health/Code Review

Description

Code Health group: Current status, next steps & discussion on best code review practices.

Questions to answer and discuss

Question:
Significance:

Question:
Significance:

Related Issues

  • ...
  • ...

Pre-reading for all Participants

  • [add links here]

Notes document(s)

[link to notes document (gdoc and / or etherpad)]

Notes and Facilitation guidance

https://www.mediawiki.org/wiki/Wikimedia_Technical_Conference/2019/NotesandFacilitation


Session Leader(s)

  • [name]
  • [name]

Session Scribes

  • [name]
  • [name]

Session Facilitator

  • [name]

Session Style / Format

  • [what type of format will this session be?]

Session Leaders please:

  • Add more details to this task description.
  • Coordinate any pre-event discussions (here on Phab, IRC, email, hangout, etc).
  • Outline the plan for discussing this topic at the event.
  • Optionally, include what this session will not try to solve.
  • Update this task with summaries of any pre-event discussions.
  • Include ways for people not attending to be involved in discussions before the event and afterwards.

Post-event summary:

  • ...

Post-event action items:

  • ...

Event Timeline

debt created this task.Fri, Oct 4, 3:49 PM
kostajh added a subscriber: kostajh.

I'd be interested to hear specific feedback about how the codehealth pipeline assists (or doesn't) with code review. But there are potentially many directions this session could go, and I'm fine if that doesn't end up as one of the discussion points.

I'd be interested to hear specific feedback about how the codehealth pipeline assists (or doesn't) with code review. But there are potentially many directions this session could go, and I'm fine if that doesn't end up as one of the discussion points.

FWIW I love it. I have caught a few bugs in my patches before a code reviewer even saw my patch. It has also incentivised me to write more tests thanks to nice code coverage (not necessarily good ones, but better than no tests) and those tests have uncovered more bugs. -> Less round trips in actual code review.

hashar awarded a token.Mon, Oct 7, 2:07 PM
hashar added a subscriber: hashar.Mon, Oct 7, 2:10 PM

I will be more than happy to assist for the code review principles and experience as well as how code health tools assist. Writing good reviews requires some good guidelines and principles.

I'm happy to help with this session when it comes to code review aspects.

Depending on the amount of time we have for this session, I suggest that we limit it's scope to Code Review vs the broader Code Health topic. If we have enough time, I'd be happy to provide and overview of the other Code Health Group activities in play.

Happy to co-lead this session with Andre.

Addshore added a subscriber: Addshore.
TheDJ added a subscriber: TheDJ.Sat, Oct 12, 3:07 PM

I'd be interested in code health and it would be lovely if we could see about getting some statistics from the past year for instance, see if we can also find some empirical evidence next to the anecdotal evidence about progress made etc.

Tgr awarded a token.Sun, Oct 13, 8:42 PM
Tgr added a subscriber: Tgr.Sun, Oct 13, 8:44 PM

Depending on the amount of time we have for this session, I suggest that we limit it's scope to Code Review vs the broader Code Health topic.

+1. As far as I can see code health work is going well (re: @kostajh I would echo Niklas, I only wrote a handlful of patches that went through code health checks, and it already helped me catch mistakes; and the UI is much saner than our traditional CI), while code review is fundamentally broken and we aren't really sure what to do about it.

Hey all, thanks for all the comments and support! @Jrbranaa, @Aklapper please go ahead and re-assign the task to one of you :-)

Jrbranaa claimed this task.Thu, Oct 17, 3:11 PM