PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• Mholloway
	Oct 5 2019, 4:38 PM

Description

I believe this was caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/540696/.

Steps to Reproduce: $ curl https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=siteinfo

Actual Results:

Oct  5 16:24:43 deployment-mediawiki-09: {
    "message": "syntax error, unexpected T_CONST, expecting T_VARIABLE",
    "file": "/srv/mediawiki/php-master/includes/title/NamespaceInfo.php",
    "line": 59,
    "context": [],
    "backtrace": [
        {
            "file": "/srv/mediawiki/php-master/includes/title/NamespaceInfo.php",
            "line": 59
        },
        {
            "file": "/srv/mediawiki/php-master/includes/AutoLoader.php",
            "line": 109,
            "function": "include",
            "args": [
                "/srv/mediawiki/php-master/includes/title/NamespaceInfo.php"
            ]
        },
        {
            "file": "/srv/mediawiki/php-master/includes/Setup.php",
            "line": 468,
            "function": "autoload",
            "class": "AutoLoader",
            "type": "::",
            "args": [
                "NamespaceInfo"
            ]
        },
        {
            "file": "/srv/mediawiki/php-master/includes/WebStart.php",
            "line": 81,
            "function": "include",
            "args": [
                "/srv/mediawiki/php-master/includes/Setup.php"
            ]
        },
        {
            "file": "/srv/mediawiki/php-master/api.php",
            "line": 36,
            "function": "include",
            "args": [
                "/srv/mediawiki/php-master/includes/WebStart.php"
            ]
        },
        {
            "file": "/srv/mediawiki/w/api.php",
            "line": 3,
            "function": "include",
            "args": [
                "/srv/mediawiki/php-master/api.php"
            ]
        }
    ]
}

Event Timeline

• Mholloway created this task.Oct 5 2019, 4:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2019, 4:38 PM

It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not running on HHVM anymore, right???

Interestingly, for me, requests from Chromium are served with PHP7.2 and are fine, but all other clients (FF, curl, MCS) are served with HHVM and hit the error.

Update: https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=siteinfo is now completing successfully (powered by php7.2) when I request it with Firefox.

In T234723#5549250, @Daimona wrote:

It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not running on HHVM anymore, right???

Not according to that same query in Special:ApiSandbox, or the api using https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=jsonfm&meta=siteinfo. Is that query cached somehow?

And just when I shuffled https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=jsonfm&meta=siteinfo to https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=siteinfo&format=jsonfm and then to https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=siteinfo it's gone.

In T234723#5549250, @Daimona wrote:

It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not running on HHVM anymore, right???

I think we haven't properly switched over the beta API server to use PHP 7 yet.

Krenair claimed this task.Oct 5 2019, 4:58 PM

added

profile::mediawiki::vhost_feature_flags:
  php72_only: true

to deployment-mediawiki-09, like we did with deployment-mediawiki-07 the other day

looks fine:

$ curl 'https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=siteinfo' -Is | head -n1
HTTP/2 200

should probably roll this across the rest of the beta cluster VMs, and uninstall HHVM. Can someone confirm it's all looking okay for them too?

shinken seems happy: <shinken-wm> RECOVERY - App Server Main HTTP Response on deployment-mediawiki-09 is OK: HTTP OK: HTTP/1.1 200 OK - 48091 bytes in 0.798 second response time

Looking good here.

Krenair closed this task as Resolved.Oct 5 2019, 5:47 PM

Krenair edited projects, added Beta-Cluster-Infrastructure; removed MediaWiki-General, Beta-Cluster-reproducible.

PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLEClosed, ResolvedPublicBUG REPORTActions

Description

Event Timeline

PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE
Closed, ResolvedPublicBUG REPORT
Actions