Page MenuHomePhabricator

FRUEC: Allow multiple files to contribute to aggregate bannerimpressions cells
Closed, ResolvedPublic2 Estimated Story Points


As currently implemented, FRUEC assumes that log files will contain exclusively events with timestamps within the 15-minute period corresponding to the timestamp in the filename. However, there can be overlap in timestamps for events from multiple files.

This means that for the aggregate data in the bannerimpressions table, it is not possible to always link each aggregate cells to a single file. Removing that link would break FRUEC's system for purging events from specific files.

It should be possible to fix this by changing the DB schema, creating link tables between files and aggregate bannerimpressions cells, and storing in the link tables the total impression counts aggregated from a given file for each cell.

Spun out from T234352.

Event Timeline

AndyRussG created this task.Oct 6 2019, 2:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2019, 2:16 AM

Change 541155 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[wikimedia/fundraising/FRUEC@master] Allow bannerimpressions cells from multiple files

Change 541155 merged by AndyRussG:
[wikimedia/fundraising/FRUEC@master] Allow bannerimpressions cells from multiple files

AndyRussG closed this task as Resolved.Oct 13 2019, 11:19 PM

Now deployed, seems to work!