Page MenuHomePhabricator

Step 2: show tainted icon after canceling editing if icon was shown before
Closed, ResolvedPublic5 Estimated Story Points

Description

Problem:
When an editor attempts to fix a tainted reference warning but then cancels the edit we want to continue showing them the warning icon. This is for example useful if they cancel the edit to re-read the warning.

BDD
GIVEN a statement with a tainted reference warning
WHEN I click edit
AND I cancel the edit
THEN the warning is still there

Acceptance criteria:

  • the warning icon is shown again after canceling edit mode on a tainted reference statement

Note:

  • the warning should not be shown in edit mode

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher renamed this task from Hide icon if any edit is made to statement reference after the icon has been shown to Step 2: Hide icon if any edit is made to statement reference after the icon has been shown.Oct 11 2019, 10:31 AM
Lydia_Pintscher renamed this task from Step 2: Hide icon if any edit is made to statement reference after the icon has been shown to Step 2: show tainted icon after canceling editing if icon was shown before.Oct 11 2019, 10:42 AM
Lydia_Pintscher updated the task description. (Show Details)