Step 2: show tainted icon after canceling editing if icon was shown before
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
When an editor attempts to fix a tainted reference warning but then cancels the edit we want to continue showing them the warning icon. This is for example useful if they cancel the edit to re-read the warning.

BDD
GIVEN a statement with a tainted reference warning
WHEN I click edit
AND I cancel the edit
THEN the warning is still there

Acceptance criteria:

the warning icon is shown again after canceling edit mode on a tainted reference statement

Note:

the warning should not be shown in edit mode

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T234790 Step 2: show tainted icon after canceling editing if icon was shown before
Resolved	Rosalie_WMDE	T242116 Add an editstate to Store
Resolved	Rosalie_WMDE	T242117 Test that icon shows only when taintedState is true and editState is false
Resolved	Rosalie_WMDE	T242118 Change save hook to set taintState to false
Resolved	Tarrow	T242119 StopEditing Hook should dispatch STOP_EDIT action
Resolved	hoo	T242121 Add Cancel hook
Resolved	Rosalie_WMDE	T242123 change showing taintedIcon rules
Resolved	Rosalie_WMDE	T243817 Browsertest for showing tainted icon after canceling edit

Event Timeline

Lydia_Pintscher created this task.Oct 7 2019, 8:21 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 7 2019, 8:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lydia_Pintscher moved this task from Backlog to Needs Work on the Wikidata Tainted References board.Oct 7 2019, 8:21 AM

Lydia_Pintscher renamed this task from Hide icon if any edit is made to statement reference after the icon has been shown to Step 2: Hide icon if any edit is made to statement reference after the icon has been shown.Oct 11 2019, 10:31 AM

Lydia_Pintscher renamed this task from Step 2: Hide icon if any edit is made to statement reference after the icon has been shown to Step 2: show tainted icon after canceling editing if icon was shown before.Oct 11 2019, 10:42 AM

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher moved this task from Needs Work to Ready to estimate on the Wikidata Tainted References board.

WMDE-leszek set the point value for this task to 5.Oct 14 2019, 2:09 PM

WMDE-leszek moved this task from Ready to estimate to Ready to pick up on the Wikidata Tainted References board.

noarave edited projects, added Wikidata-Tainted-References-Sprint6; removed Wikidata Tainted References.Nov 25 2019, 1:15 PM

WMDE-leszek edited projects, added Wikidata Tainted References; removed Wikidata-Tainted-References-Sprint6.Dec 9 2019, 12:14 PM

WMDE-leszek edited projects, added Wikidata-Tainted-References-Sprint8; removed Wikidata Tainted References.Jan 6 2020, 10:39 AM

Tarrow mentioned this in T234789: Step 2: confirm existing reference when edit doesn't influence it.Jan 6 2020, 3:12 PM

Rosalie_WMDE moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint8 board.Jan 6 2020, 3:44 PM

Rosalie_WMDE claimed this task.Jan 6 2020, 4:25 PM

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Jan 9 2020, 8:41 AM

Rosalie_WMDE added a subscriber: Rosalie_WMDE.