Page MenuHomePhabricator

Introduce “Match system theme” setting
Open, MediumPublic4 Estimate Story Points

Description

Why are we doing this?

Android 10 newly introduced a new system setting called “Dark theme”, which allows users to toggle a system wide dark appearance.

In the Wikipedia app, users currently have to manually adapt their (reading) theme setting based on their system setting.

Suggested solution

Enhance the “App theme” setting and bottom sheet in articles with a Match system theme toggle.

Match system theme on (System dark theme off)Match systeme theme off (System dark theme on)Match system theme off

If users have set “Match system theme” to on (active toggle), they are able to choose which theme they’d like to use for the two states, see table below.

System dark theme OffSystem dark theme On
“Match system theme” OffLight, Sepia, Dark, BlackLight, Sepia, Dark, Black
“Match system theme” OnLight, SepiaDark, Black

Some additional conditions:

  • The app’s “Match system theme” setting is off by default.
  • If the app’s “Match system theme” setting is enabled and the system’s dark theme setting is off, the app defaults to light theme.
  • If the app’s “Match system theme” is enabled and the system’s dark theme setting is on, the app defaults to use the black theme.
  • If the “Match system theme” setting is enabled, theme options that are not available are in disabled state (greyed out/reduced opacity).
  • The app remembers if users change their preferred themes.

Starting point for researching:

https://developer.android.com/guide/topics/ui/look-and-feel/darktheme

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2019, 2:53 PM
Charlotte triaged this task as Medium priority.Oct 8 2019, 4:20 PM
Charlotte set the point value for this task to 4.
Hmxhmx added a subscriber: Hmxhmx.Nov 2 2019, 3:52 PM

Impeccable work @Sharvaniharan 👏 Hope that Android is going to introduce an automatic dark mode (based on daytime) soon.

Moving this to QA signoff!

Florian removed a subscriber: Florian.Nov 15 2019, 7:19 PM
ABorbaWMF added a subscriber: ABorbaWMF.

I am not seeing the theme toggle on 2.7.50303-beta-2019-11-19 on Galaxy S10 and Galaxy Tab

@ABorbaWMF Are they running Android Q? This is only available for Q.

@Sharvaniharan Hey, yes! Sorry about that. I am working on getting android 10 up and running

Np! Thank you for the update @ABorbaWMF

Looks good to me on Android 10 on 2.7.50307-alpha-2020-01-06