| Opsylac | |
| Oct 7 2019, 9:15 PM |
| F31666604: Screen Shot 2020-03-05 at 12.11.37.png | |
| Mar 5 2020, 11:08 AM |
| F31646621: Screenshot from 2020-02-27 10-42-35.png | |
| Feb 27 2020, 10:43 AM |
| F31646618: Screenshot from 2020-02-27 10-43-18.png | |
| Feb 27 2020, 10:43 AM |
| F30582630: Screenshot_20191007-231656_Fennec F-Droid.jpg | |
| Oct 7 2019, 9:17 PM |
| F30582552: Screenshot_20191007-230935_Fennec F-Droid.jpg | |
| Oct 7 2019, 9:15 PM |
Currently, some information is displayed as a caption covering the lower part of the image.
It is sometimes problematic because it hides important elements that need to be depicted. Here is an example where almost half the image is hidden.
It would be great if this information was displayed elsewhere, for example with the rest of the other information just below :)
Thanks in advance!
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Fix image overlay text covering the image | Gabrielchihonglee | labs/tools/Isa | master | +78 -76 |
Change 575216 had a related patch set uploaded (by Gabrielchihonglee; owner: Gabrielchihonglee):
[labs/tools/Isa@master] Fix image overlay text covering the image
You mean even after applying this patch: https://gerrit.wikimedia.org/r/#/c/labs/tools/Isa/+/575216/ ?
@Gabrielchihonglee the screenshot below is a situation where the File attribute of the image is blocked partially following your recent change.
Change 575216 abandoned by Eugene233:
[labs/tools/Isa@master] Fix image overlay text covering the image
Reason:
PS not worked on for a while.
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Hello, I'd like to work on this task.
I investigated the issue and found that the license/author information is displayed through .image-overlay inside .img-holder and is positioned using absolute positioning, which appears to cause the information to cover part of the image.
I'm reviewing the previous abandoned patch and testing possible solutions to display this information without obscuring the image, including checking the behavior on mobile devices.
Thanks!
Hello! I have submitted a patch for this task.
Gerrit change: https://gerrit.wikimedia.org/r/c/labs/tools/Isa/+/1308348
This patch moves the image attribution (author, credit, and license) below the image so it no longer obscures important parts of the image while keeping the attribution visible.
Thank you for reviewing!
@Shashwatojha369 thank you for your contribution. However, ISA was migrated to gitlab a while ago.
