TreeModifier: remover does not skip over a deleted node immediately following a text node
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dchan
	Oct 8 2019, 6:53 AM

Description

Steps to reproduce:

In VisualEditor standalone, edit <p>abc</p>
Select from between b and c to the end of the paragraph (so range 3-6)
Press Delete

Expected behaviour:

c is deleted

Actual behaviour:

An Error is thrown with the following stacktrace:

ve.dm.TreeModifier.js:534 Uncaught Error: Remover and inserter unexpectedly diverged
    at VeDmTreeModifier.ve.dm.TreeModifier.processRetain (ve.dm.TreeModifier.js:534)
    at VeDmTreeModifier.ve.dm.TreeModifier.processLinearOperation (ve.dm.TreeModifier.js:407)
    at VeDmTreeModifier.ve.dm.TreeModifier.calculateTreeOperations (ve.dm.TreeModifier.js:390)
    at VeDmTreeModifier.ve.dm.TreeModifier.process (ve.dm.TreeModifier.js:355)
    at VeDmTransactionProcessor.ve.dm.TransactionProcessor.process (ve.dm.TransactionProcessor.js:111)
    at VeDmDocument.ve.dm.Document.commit (ve.dm.Document.js:341)
    at VeDmSurface.ve.dm.Surface.changeInternal (ve.dm.Surface.js:950)
    at VeDmSurface.ve.dm.Surface.change (ve.dm.Surface.js:918)
    at VeDmSurfaceFragment.ve.dm.SurfaceFragment.change (ve.dm.SurfaceFragment.js:126)
    at VeDmSurfaceFragment.ve.dm.SurfaceFragment.delete (ve.dm.SurfaceFragment.js:965)

This is because if the ve.dm.TreeCursor is at the end of a text node and an ignored node follows, #crossIgnoredNodes should step out of the text node and cross the ignored node, but in fact it does not.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update VE core submodule to 2fc83d833	mediawiki/extensions/VisualEditor	wmf/1.35.0-wmf.1	+1 -1
Update VE core submodule to 27e0abf04	mediawiki/extensions/VisualEditor	REL1_34	+1 -1
TreeCursor: cross ignored nodes properly from the end of a text node	VisualEditor/VisualEditor	wmf/1.35.0-wmf.1	+46 -2
TreeCursor: cross ignored nodes properly from the end of a text node	VisualEditor/VisualEditor	REL1_34	+46 -2
TreeCursor: cross ignored nodes properly from the end of a text node	VisualEditor/VisualEditor	master	+46 -2
Update VE core submodule to master (2f2cdd89d)	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T233101: Wikilinking a label with a HTML entities in it freezes the Visual Editor
T215567: Split TreeModifier into a tree diff generator and tree diff applier
T234489: Problems with deleting/cutting/moving references in VisualEditor
T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways
Mentioned Here: rGVED2fc83d833664: TreeCursor: cross ignored nodes properly from the end of a text node
rGVED27e0abf04db7: TreeCursor: cross ignored nodes properly from the end of a text node
rGVED2f2cdd89dbf5: Merge "TreeCursor: cross ignored nodes properly from the end of a text node"
T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways

Event Timeline

dchan created this task.Oct 8 2019, 6:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2019, 6:53 AM

dchan mentioned this in T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways.Oct 8 2019, 6:57 AM

AxelBoldt subscribed.Oct 8 2019, 7:05 AM

Titore subscribed.Oct 8 2019, 10:07 AM

matmarex mentioned this in T234489: Problems with deleting/cutting/moving references in VisualEditor.Oct 8 2019, 8:07 PM

matmarex subscribed.

Emanuele676 subscribed.Oct 9 2019, 2:13 PM

Steps to reproduce real-life example (from T234142):

Edit https://en.wikipedia.org/w/index.php?title=Nils_Grandelius&veaction=edit
From the first paragraph, try to delete "Sweden[2]"

Expected behaviour: Sweden[2] disappears.

Actual behaviour: An Error is thrown "Remover and inserter unexpectedly diverged".

Change 541995 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] TreeCursor: cross ignored nodes properly from the end of a text node

https://gerrit.wikimedia.org/r/541995

gerritbot added a project: Patch-For-Review.Oct 10 2019, 1:13 AM

Change 541995 fixes the real-life example above.

Looks like @dchan is working on this and there is a patch for code review.

JTannerWMF moved this task from Incoming to Code review on the VisualEditor (Current work) board.Oct 10 2019, 3:42 PM

Change 541995 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TreeCursor: cross ignored nodes properly from the end of a text node

https://gerrit.wikimedia.org/r/541995

Change 542177 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2f2cdd89d)

https://gerrit.wikimedia.org/r/542177

Change 542177 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2f2cdd89d)

https://gerrit.wikimedia.org/r/542177

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2019, 8:10 PM

Change 542228 had a related patch set uploaded (by Bartosz Dziewoński; owner: Divec):
[VisualEditor/VisualEditor@wmf/1.35.0-wmf.1] TreeCursor: cross ignored nodes properly from the end of a text node

https://gerrit.wikimedia.org/r/542228

Change 542229 had a related patch set uploaded (by Bartosz Dziewoński; owner: Divec):
[VisualEditor/VisualEditor@REL1_34] TreeCursor: cross ignored nodes properly from the end of a text node

https://gerrit.wikimedia.org/r/542229

Change 542230 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.1] Update VE core submodule to 2fc83d833

https://gerrit.wikimedia.org/r/542230

Change 542231 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@REL1_34] Update VE core submodule to 27e0abf04

https://gerrit.wikimedia.org/r/542231

Change 542229 merged by jenkins-bot:
[VisualEditor/VisualEditor@REL1_34] TreeCursor: cross ignored nodes properly from the end of a text node

https://gerrit.wikimedia.org/r/542229

Change 542228 merged by jenkins-bot:
[VisualEditor/VisualEditor@wmf/1.35.0-wmf.1] TreeCursor: cross ignored nodes properly from the end of a text node

https://gerrit.wikimedia.org/r/542228

Change 542231 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@REL1_34] Update VE core submodule to 27e0abf04

https://gerrit.wikimedia.org/r/542231

Change 542230 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.1] Update VE core submodule to 2fc83d833

https://gerrit.wikimedia.org/r/542230

Mentioned in SAL (#wikimedia-operations) [2019-10-10T21:39:25Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.1/extensions/VisualEditor/lib/ve/src/dm/ve.dm.TreeCursor.js: T234881 TreeCursor: cross ignored nodes properly from the end of a text node (duration: 00m 54s)