Page MenuHomePhabricator

Bad value for parameter $oldContent: must be a TextContent|null
Closed, DuplicatePublic

Description

Error

MediaWiki version: 1.34.0-wmf.25

message
Bad value for parameter $oldContent: must be a TextContent|null

Impact

  • 44 such events in the last hour, seems to be intentional

Notes

  • This seems to be either some pen testing or a malicious search for vulnerabilities. But the asserts seems to catch all of them, so we should be fine in that regard.

Details

Request ID
XZxVmgpAADgAAC0mR9YAAACP
Request URL
/w/index.php?diff=2vAZRoIh'));select%20pg_sleep(5);%20--%20&oldid=1021909340&title=Q7703332&type=revision
Stack Trace
exception.trace
#0 /includes/diff/SlotDiffRenderer.php(86): Wikimedia\Assert\Assert::parameterType(string, Wikibase\ItemContent, string)
#1 /includes/diff/TextSlotDiffRenderer.php(104): SlotDiffRenderer->normalizeContents(Wikibase\ItemContent, WikitextContent, string)
#2 /includes/diff/DifferenceEngine.php(1075): TextSlotDiffRenderer->getDiff(Wikibase\ItemContent, WikitextContent)
#3 /includes/diff/DifferenceEngine.php(993): DifferenceEngine->getDiffBody()
#4 /includes/diff/DifferenceEngine.php(955): DifferenceEngine->getDiff(string, string, string)
#5 /includes/diff/DifferenceEngine.php(717): DifferenceEngine->showDiff(string, string, string)
#6 /includes/page/Article.php(951): DifferenceEngine->showDiffPage(boolean)
#7 /includes/page/Article.php(632): Article->showDiffPage()
#8 /extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(79): Article->view()
#9 /extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(54): Wikibase\ViewEntityAction->showEntityPage()
#10 /includes/MediaWiki.php(511): Wikibase\ViewEntityAction->show()
#11 /includes/MediaWiki.php(302): MediaWiki->performAction(Article, Title)
#12 /includes/MediaWiki.php(900): MediaWiki->performRequest()
#13 /includes/MediaWiki.php(527): MediaWiki->main()
#14 /index.php(44): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Event Timeline

Michael created this task.Oct 8 2019, 10:01 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 8 2019, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr added a subscriber: Tgr.Oct 8 2019, 10:20 AM

That's a duplicate of T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null (minus the pentesting aspect, which I would not be worried about).

That's a duplicate of T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null (minus the pentesting aspect, which I would not be worried about).

Ah, that is an old ticket from before the phatality id was introduced. Good to know :)

What is this phatality? I can’t find any information about it on Wikitech or MediaWiki.org.

What is this phatality? I can’t find any information about it on Wikitech or MediaWiki.org.

It's new and it makes creating (and searching for existing) errors tickets in phabricator from kibana much easier: https://phabricator.wikimedia.org/phame/post/view/177/introducing_phatality/

Thanks, I’ve added links to that blog post on-wiki.