Maniphest T234931

Diff screen - Show empty state if there are no changes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tsevener
	Oct 8 2019, 2:58 PM

Tags

Referenced Files

	F31098951: No difference between revisions.pdf
	Nov 18 2019, 10:15 PM

	F31091669: IMG_D06727E3B9BD-1.jpeg
	Nov 15 2019, 7:37 PM

	F31091668: IMG_731D614D44B6-1.jpeg
	Nov 15 2019, 7:37 PM

	F30603395: Empty state: diffs.png
	Oct 9 2019, 3:25 PM

Subscribers

Description

If a user chooses two revisions that have no changes between them, we need to show an empty state.

No changes empty state

https://zpl.io/a8Jx3Yg

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		LGoto	T216665 As a curating editor I want to be able to see a useable page history and take revert actions
		Resolved		• JMinor	T228792 Compare revision: as a user I want to compare two revisions in my history
		Resolved		Tsevener	T228793 Add revision comparison ("diff") screen
		Resolved		Tsevener	T234931 Diff screen - Show empty state if there are no changes

Event Timeline

Tsevener created this task.Oct 8 2019, 2:58 PM

• JMinor removed Tsevener as the assignee of this task.Oct 8 2019, 6:12 PM

• JMinor triaged this task as Medium priority.

• JMinor moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

cmadeo updated the task description. (Show Details)Oct 9 2019, 3:25 PM

cmadeo moved this task from Needs Design to Needs Acceptance Criteria on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

• JMinor moved this task from Needs Acceptance Criteria to Ready for Development on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Oct 15 2019, 6:17 PM

Tsevener claimed this task.Oct 15 2019, 6:19 PM

LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Oct 21 2019, 6:54 PM

Tsevener removed Tsevener as the assignee of this task.Oct 29 2019, 6:16 PM

Tsevener claimed this task.Oct 30 2019, 9:36 PM

Tsevener moved this task from Ready for Development to Doing on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

Tsevener moved this task from Doing to Blocked or Waiting on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Oct 31 2019, 3:32 PM

Tsevener moved this task from Blocked or Waiting to Doing on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

Tsevener moved this task from Doing to Needs Code Review on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 1 2019, 5:26 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 8 2019, 9:16 PM

Tsevener moved this task from Waiting for Build to Needs QA on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 13 2019, 2:44 PM

Sending to design for a quick check on the drop shadow on dark themes

IMG_731D614D44B6-1.jpeg (2×1 px, 531 KB)

IMG_D06727E3B9BD-1.jpeg (2×2 px, 428 KB)

ABorbaWMF moved this task from Needs QA to Needs Design Review on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 15 2019, 7:37 PM

Good catch @ABorbaWMF
Here's an updated graphic without the glow-y shadow behind it:

No difference between revisions.pdf23 KBDownload

A few more small tweaks:

the HR between the two sets of revision info is looking thick on dark mode, could we reduce it to 1pt?
it looks like the HR below the revision info on dark mode is missing, can we make sure it's there?
on iPad can we extend the background color in the revision info section to be full width?

Tsevener moved this task from Ready for Development to Doing on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 20 2019, 2:04 AM

https://github.com/wikimedia/wikipedia-ios/pull/3348

Tsevener moved this task from Doing to Needs Code Review on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 20 2019, 7:50 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 21 2019, 8:57 PM

Tsevener moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 22 2019, 2:32 AM

Looking good! Thanks so much @Tsevener!

Looks good on 6.5.0 (1699)

• JMinor closed this task as Resolved.Dec 2 2019, 6:49 PM