Page MenuHomePhabricator

CleanupEmptyCategories should not be subclass of LoggedUpdateMaintenance
Open, Needs TriagePublic

Description

The cleanupEmptyCategories.php maintenance script is not meant to be a script to be run once in the entire lifetime of the wiki. However, its class extends LoggedUpdateMaintenance, causing it to do nothing when the script has been run once, which makes no sense.

See T167669#3561945 and Topic:V8te8titzif3wlc8

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Oct 9, 9:00 AM
Kghbln added a subscriber: Kghbln.EditedWed, Oct 9, 8:45 PM

Without using the --force parameter the output of the script is

...Update 'cleanup empty categories' already logged as completed.

in contrast to e.g.

Adding empty categories with description pages...
Removing empty categories without description pages...
--mode=remove --begin=Weinstube_im_Landkreis
Category cleanup complete.

Setup

  • MediaWiki 1.31.4 (171d96b) 30. Sep. 2019, 19:35
  • PHP 7.2.13-1+0~20181207100540.13+stretch~1.gbpf57305 (apache2handler)
  • MariaDB 10.1.37-MariaDB-0+deb9u1