Add maxlength attribute to ResizingTextField
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Oct 9 2019, 10:12 AM

Description

For now, a direct maxlength on the underlying <textarea> should be fine, though this counts UTF-16 code units and the underlying PHP probably doesn’t (though I haven’t checked whether that counts code points, UTF-8 bytes or something else).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	bridge: allow adding max length to ResizingTextField	mediawiki/extensions/Wikibase	master	+206 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T224833 first client edit for simple typo
Resolved	Lydia_Pintscher	T229241 restrict length of string value input
Resolved	Michael	T235039 Add maxlength attribute to ResizingTextField

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 9 2019, 10:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:12 AM

Michael claimed this task.Oct 10 2019, 12:09 PM

Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-7 board.

Restricted Application added a project: User-Michael. · View Herald TranscriptOct 10 2019, 12:09 PM

Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.Oct 10 2019, 12:09 PM

Change 542099 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: allow adding max length to ResizingTextField

https://gerrit.wikimedia.org/r/542099

gerritbot added a project: Patch-For-Review.Oct 10 2019, 1:12 PM

Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.Oct 10 2019, 1:23 PM

Michael moved this task from ⏳ In progress to 💬 waiting on other's work or feedback on the User-Michael board.Oct 10 2019, 1:30 PM

Change 542099 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: allow adding max length to ResizingTextField

https://gerrit.wikimedia.org/r/542099

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2019, 3:10 PM

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 10 2019, 3:12 PM

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 10 2019, 4:00 PM