Page MenuHomePhabricator

Add maxlength attribute to ResizingTextField
Closed, ResolvedPublic

Description

For now, a direct maxlength on the underlying <textarea> should be fine, though this counts UTF-16 code units and the underlying PHP probably doesn’t (though I haven’t checked whether that counts code points, UTF-8 bytes or something else).

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: allow adding max length to ResizingTextField

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:12 AM
Michael claimed this task.Oct 10 2019, 12:09 PM
Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-7 board.
Restricted Application added a project: User-Michael. · View Herald TranscriptOct 10 2019, 12:09 PM

Change 542099 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: allow adding max length to ResizingTextField

https://gerrit.wikimedia.org/r/542099

Change 542099 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: allow adding max length to ResizingTextField

https://gerrit.wikimedia.org/r/542099

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 10 2019, 3:12 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.