Page MenuHomePhabricator
Create Task
Maniphest T235040

Get max string length from store to ResizingTextField
Closed, ResolvedPublic
Actions

Description

We’d like to keep the StringDataValue component store-agnostic so it can be reused more easily, so the max length should be read in the surrounding component and passed through via an attribute. For the time being, that surrounding component is the DataBridge component, though in the long run there should likely be some more components in between.

Details

SubjectRepoBranchLines +/-
bridge: wire up max string length in DataBridgemediawiki/extensions/Wikibasemaster+16 -7
bridge: add stringMaxLength getter to storemediawiki/extensions/Wikibasemaster+40 -0
bridge: add maxlength to StringDataValuemediawiki/extensions/Wikibasemaster+64 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 9 2019, 10:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:12 AM
Lucas_Werkmeister_WMDE claimed this task.Oct 14 2019, 3:35 PM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-7 board.
gerritbot added a comment.Oct 14 2019, 4:25 PM

Change 542988 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add stringMaxLength getter to store

https://gerrit.wikimedia.org/r/542988

gerritbot added a project: Patch-For-Review.Oct 14 2019, 4:25 PM

Change 542989 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: wire up max string length in DataBridge

https://gerrit.wikimedia.org/r/542989

gerritbot added a comment.Oct 14 2019, 4:26 PM

Change 542990 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add maxlength to StringDataValue

https://gerrit.wikimedia.org/r/542990

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.Oct 14 2019, 4:26 PM
gerritbot added a comment.Oct 15 2019, 12:36 PM

Change 542990 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add maxlength to StringDataValue

https://gerrit.wikimedia.org/r/542990

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 15 2019, 1:00 PM
gerritbot added a comment.Oct 15 2019, 6:28 PM

Change 542988 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add stringMaxLength getter to store

https://gerrit.wikimedia.org/r/542988

gerritbot added a comment.Oct 15 2019, 6:28 PM

Change 542989 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up max string length in DataBridge

https://gerrit.wikimedia.org/r/542989

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 15 2019, 6:35 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 7:10 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.3; 2019-10-22); removed MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 15 2019, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL