Page MenuHomePhabricator

Get max string length from store to ResizingTextField
Closed, ResolvedPublic

Description

We’d like to keep the StringDataValue component store-agnostic so it can be reused more easily, so the max length should be read in the surrounding component and passed through via an attribute. For the time being, that surrounding component is the DataBridge component, though in the long run there should likely be some more components in between.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:12 AM

Change 542988 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add stringMaxLength getter to store

https://gerrit.wikimedia.org/r/542988

Change 542989 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: wire up max string length in DataBridge

https://gerrit.wikimedia.org/r/542989

Change 542990 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add maxlength to StringDataValue

https://gerrit.wikimedia.org/r/542990

Change 542990 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add maxlength to StringDataValue

https://gerrit.wikimedia.org/r/542990

Change 542988 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add stringMaxLength getter to store

https://gerrit.wikimedia.org/r/542988

Change 542989 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up max string length in DataBridge

https://gerrit.wikimedia.org/r/542989

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 15 2019, 6:35 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.