Save original revision data in store
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Oct 9 2019, 10:44 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Lucas_Werkmeister_WMDE

Description

This “shadow state” is necessary so that we can compare against it to determine if any modifications were made.

Optimizations to consider:

only store the JSON.stringify() version and compare against that
only store statements for the property we’re interested in

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	bridge: inject path to validateBridgeApplicability	Matthias Geisler	mediawiki/extensions/Wikibase	master	+56 -49
	bridge: save revision data	Matthias Geisler	mediawiki/extensions/Wikibase	master	+164 -17

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T230342 enable/disable save button depending on Bridge state
		Resolved		• Matthias_Geisler_WMDE	T235052 Save original revision data in store

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 9 2019, 10:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:44 AM

Lucas_Werkmeister_WMDE mentioned this in T235054: Add dirty state getter to store.Oct 9 2019, 10:44 AM

• Matthias_Geisler_WMDE claimed this task.Oct 16 2019, 10:30 AM

• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-7 board.Oct 16 2019, 10:40 AM

Change 543488 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: save revision data

https://gerrit.wikimedia.org/r/543488

gerritbot added a project: Patch-For-Review.Oct 16 2019, 4:21 PM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.Oct 16 2019, 4:22 PM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:29 PM

As mention in T235054 we are actually using deep compare instead a json based compare, therefore the relating patch save now a clone of the actual object instead of the json string.

Change 544908 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: inject path to validateBridgeApplicability

https://gerrit.wikimedia.org/r/544908

Change 544908 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: inject path to validateBridgeApplicability

https://gerrit.wikimedia.org/r/544908

Change 543488 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: save revision data

https://gerrit.wikimedia.org/r/543488

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 21 2019, 4:38 PM

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2019, 5:11 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 21 2019, 8:01 PM