Page MenuHomePhabricator

Save original revision data in store
Closed, ResolvedPublic

Description

This “shadow state” is necessary so that we can compare against it to determine if any modifications were made.

Optimizations to consider:

  • only store the JSON.stringify() version and compare against that
  • only store statements for the property we’re interested in

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: inject path to validateBridgeApplicability
mediawiki/extensions/Wikibase : masterbridge: save revision data

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:44 AM

Change 543488 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: save revision data

https://gerrit.wikimedia.org/r/543488

As mention in T235054 we are actually using deep compare instead a json based compare, therefore the relating patch save now a clone of the actual object instead of the json string.

Change 544908 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: inject path to validateBridgeApplicability

https://gerrit.wikimedia.org/r/544908

Change 544908 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: inject path to validateBridgeApplicability

https://gerrit.wikimedia.org/r/544908

Change 543488 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: save revision data

https://gerrit.wikimedia.org/r/543488

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 21 2019, 4:38 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.