Page MenuHomePhabricator

Translation updates failing due to protected branches on Github
Open, Needs TriagePublic

Description

We recently had an issue with SemanticMediaWiki where pushing translation to the master branch was failing.

Output:                                                                                                                                                                                                         
================                                                                                                                                                                                                
[master 652699d] Localisation updates from https://translatewiki.net.                                                                                                                                           
3 files changed, 13 insertions(+), 8 deletions(-)                                                                                                                                                              
Current branch master is up to date.                                                                                                                                                                            
Error Output:                                                                                                                                                                                                   
================                                                                                                                                                                                                
remote: error: GH006: Protected branch update failed for refs/heads/master.                                                                                                                                     
remote: error: At least 1 approving review is required by reviewers with write access.                                                                                                                          
To git@github.com:SemanticMediaWiki/SemanticMediaWiki.git                                                                                                                                                       
! [remote rejected] master -> master (protected branch hook declined)                                                                                                                                          
error: failed to push some refs to 'git@github.com:SemanticMediaWiki/SemanticMediaWiki.git'

This should not happen because the Translatewiki was added under Restrict who can push to the matching branches

Should be easy to replicate in a separate Github repository.

Ref: https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/4318

Event Timeline

abi_ created this task.Oct 9 2019, 3:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 3:32 PM
abi_ renamed this task from Translation updates failing due to protected branches to Translation updates failing due to protected branches on Github.Oct 9 2019, 3:32 PM
Nikerabbit moved this task from Backlog to Features on the translatewiki.net board.Nov 5 2019, 4:05 PM