Recurring notification email text showing subsequent donation in USD when donation was submitted in GBP
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

@Pcoombe reported this and I have confirmed myself locally submitting a donation in GBP using 'variant=upsell'

It looks like something is misbehaving in the {{ (currency ~ " " ~ amount) | l10n_currency(locale) }} call within the recurring_notification.en.html template rendering within https://gerrit.wikimedia.org/g/wikimedia/fundraising/crm/+/refs/changes/10/539210/7/sites/all/modules/thank_you/templates/html/recurring_notification.en.html#6

I also remember this patch went live which *shouldn't* be related but it touches something similar so it might be worth looking at if nothing obvious stands out https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/540232/

Details

	Subject	Repo	Branch	Lines +/-
	Use amount to match currency in recur notification	wikimedia/fundraising/crm	master	+7 -4

Customize query in gerrit

Event Timeline

jgleeson created this task.Oct 9 2019, 3:40 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptOct 9 2019, 3:40 PM

jgleeson updated the task description. (Show Details)Oct 9 2019, 3:41 PM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Oct 9 2019, 5:11 PM

• DStrine moved this task from Sprint +1 to Triage on the Fundraising-Backlog board.

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Oct 9 2019, 5:16 PM

The 2nd email is sending $msg['currency'] when it should be sending $msg['original_currency'] to the template.

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Oct 15 2019, 8:21 PM

• DStrine added a project: Fundraising Sprint Usual Subscripts.Oct 15 2019, 8:30 PM

Cstone claimed this task.Oct 16 2019, 9:13 PM

Cstone moved this task from Backlog to Doing on the Fundraising Sprint Usual Subscripts board.

Cstone moved this task from Doing to Pending Deployment on the Fundraising Sprint Usual Subscripts board.Oct 17 2019, 4:29 PM

Cstone moved this task from Pending Deployment to Deployed on the Fundraising Sprint Usual Subscripts board.Oct 18 2019, 3:37 PM

Cstone closed this task as Resolved.Oct 29 2019, 8:36 PM

I just set up a GBP 1.75 recurring upsell donation. And the notification email now says that it's for £ 2.26, which is the USD equivalent but with GBP localisation! This is wrong, and definitely a blocker to testing this outside of the US.

I checked in the civicrm_contribution_recur table and my donation is correctly recorded as GBP 1.75 there.

• DStrine added a project: Fundraising Sprint Visual Basic Instinct.Nov 6 2019, 9:42 PM

Change 549209 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Use amount to match currency in recur notification

https://gerrit.wikimedia.org/r/549209

gerritbot added a project: Patch-For-Review.Nov 6 2019, 9:52 PM

Change 549209 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Use amount to match currency in recur notification

https://gerrit.wikimedia.org/r/549209

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2019, 10:10 PM

Cstone moved this task from Backlog to Pending Deployment on the Fundraising Sprint Visual Basic Instinct board.Nov 9 2019, 12:18 AM

• DStrine added a project: Fundraising Sprint A Wrinkle in Timezones.Nov 12 2019, 9:28 PM

spatton subscribed.Nov 13 2019, 2:40 PM

Ejegg moved this task from Backlog to Deployed on the Fundraising Sprint A Wrinkle in Timezones board.Nov 13 2019, 4:29 PM

• DStrine added a project: Fundraising Sprint X-rays.Nov 26 2019, 8:57 PM

Cstone moved this task from Backlog to Deployed on the Fundraising Sprint X-rays board.Nov 26 2019, 9:53 PM

Cstone closed this task as Resolved.Dec 10 2019, 9:01 PM