Page MenuHomePhabricator
Create Task
Maniphest T235115

Split special page alias resolution from SpecialPageFactory into a separate service
Closed, DeclinedPublic
Actions

Description

This was unearthed during https://gerrit.wikimedia.org/r/c/mediawiki/core/+/535657 for T232506: Inject services into special pages.

Proposed on IRC.

This will decouple the alias resolution from the special page factory, allowing the PermissionsManager to manage special page permissions independently of the SpecialPageFactory.

Original problem

From the change linked above:

[...] The move of the call to the SpecialPage_initList hook to the service construction is what caused the problem; MobileFrontend does some preference related stuff in a hook handler, which inadvertently calls the PreferencesFactory, which needs the PermissionsManager.

A MobileFrontend hook handler for SpecialPage_initList required the PermissionManager (indirectly I believe), which relies on the SpecialPageFactory, causing a circular dependency.

Related Objects
Search...

Event Timeline

Mainframe98 created this task.Oct 9 2019, 5:08 PM
Mainframe98 added a comment.Oct 9 2019, 5:31 PM

Unfortunately, any alias resolver needs to know the list of special pages to know which special page belongs to which alias, which brings us back to the original issue, where extensions will (accidentally) need to specify special pages, but cannot do that without access to services that use the alias resolver.

DannyS712 moved this task from To triage to SpecialPage system on the MediaWiki-Special-pages board.Oct 10 2019, 5:30 AM
DannyS712 subscribed.Apr 8 2020, 4:28 PM
Mainframe98 closed this task as Declined.Oct 1 2021, 4:01 PM

This issue might be a valid concern, however, T259960 hasn't encountered it yet, therefore I'm going ahead and declining this.

The circumstances have also changed; Authority has been introduced as a concept, removing PermissionManager from some execution paths and changes in extending core special pages make the original issue less of a thing.

Mainframe98 removed Mainframe98 as the assignee of this task.Oct 1 2021, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits