Page MenuHomePhabricator
Create Task
Maniphest T235167

When there are no hideable caption languages on the File page, we still get a link saying "show 0 more languages"
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. upload a file, add an English caption
  2. view the file page
  3. note the link saying "Show 0 more languages"

Link should not be shown at all if there are no hidden languages

Details

SubjectRepoBranchLines +/-
Don't create a 'show x more languages' link if there are none to showmediawiki/extensions/WikibaseMediaInfomaster+16 -14
Customize query in gerrit

Event Timeline

Cparle created this task.Oct 10 2019, 12:00 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptOct 10 2019, 12:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 10 2019, 12:01 PM

Change 542091 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Don't create a 'show x more languages' link if there are none to show

https://gerrit.wikimedia.org/r/542091

gerritbot added a project: Patch-For-Review.Oct 10 2019, 12:01 PM
Cparle edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 10 2019, 12:05 PM
Cparle moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 10 2019, 2:39 PM
gerritbot added a comment.Oct 10 2019, 3:07 PM

Change 542091 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Don't create a 'show x more languages' link if there are none to show

https://gerrit.wikimedia.org/r/542091

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2019, 3:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 10 2019, 4:00 PM
• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 24 2019, 12:27 AM
• Ramsey-WMF closed this task as Resolved.Oct 24 2019, 12:30 AM
• Ramsey-WMF claimed this task.
• Ramsey-WMF subscribed.

Tested on prod and works.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL