Page MenuHomePhabricator

PPFrame_Hash.php: hardcoded english
Open, LowestPublic


PPFrame_Hash::expand() has hardcoded english, which can be present for users:

  • Expansion depth limit exceeded
  • Node-count limit exceeded



Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:56 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz21521.
bzimport added a subscriber: Unknown Object (MLST).

These strings are only used in comments at the bottom of the parser output, for debugging purposes. Recommend WONTFIX: other debugging output isn't localized either.

No, I mean Preprocessor_DOM.php, r55795, line 882 and 886

See also Preprocessor_Hash.php, r55795, line 860 and 863

That text is visible in the HTML-Source.

(In reply to comment #2)

That text is visible in the HTML-Source.

Yes, it is for debugging purposes only. Closing as WONTFIX per Roan's comment.

matmarex added a subscriber: matmarex.

We localize other error messages. This hardcoded text was reported recently in T243812. I think this issue was valid 10 years ago and is still valid now :)

cscott claimed this task.
cscott added a subscriber: cscott.

Preprocessor_DOM was removed from core in 5cbb64f56ad39a117d3c668e89781780f4f029ee . Closing.

matmarex reopened this task as Open.EditedJan 28 2020, 10:20 PM

The code now lives in PPFrame_Hash.php, but it's still there.

cscott renamed this task from Preprocessor_DOM.php: hardcoded english to PPFrame_Hash.php: hardcoded english.Jan 28 2020, 10:26 PM
cscott updated the task description. (Show Details)
Aklapper added a subscriber: Aklapper.

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see for tips how to best manage your individual work in Phabricator.