⚓ T235222 Scroll-past-infobox not working on many pages

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+6 -6	Follow-up I8373a7a: Always treat sections as strings
	mediawiki/extensions/MobileFrontend	master	+7 -3	identifyLeadParagraph: Ignore invisible nodes, slugs and whitespace

Esanders created this task.Oct 10 2019, 9:37 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 10 2019, 9:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 542246 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] identifyLeadParagraph: Ignore invisible nodes, slugs and whitespace

https://gerrit.wikimedia.org/r/542246

gerritbot added a project: Patch-For-Review.Oct 10 2019, 10:17 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Oct 10 2019, 10:17 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Esanders claimed this task.Oct 11 2019, 12:57 PM

Change 542246 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] identifyLeadParagraph: Ignore invisible nodes, slugs and whitespace

https://gerrit.wikimedia.org/r/542246

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Oct 16 2019, 9:33 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2019, 10:11 PM

@matmarex: This is not yet on en.wiki right? Why did @ReleaseTaggerBot not tag this? 😕

It's not on en.wiki yet, it should be included in the next week's train deployment. No idea about ReleaseTaggerBot.

matmarex added a project: Editing QA.Oct 22 2019, 11:43 AM

Okay, checked it for the listed articles on en.wiki, scroll is now moving past the infobox for those articles.

Ryasmeen edited projects, added Verified; removed Editing QA.Oct 22 2019, 6:25 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

ppelberg closed this task as Resolved.Jan 21 2020, 2:04 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 21 2020, 2:04 AM

Esanders reopened this task as Open.Jun 11 2020, 12:04 PM

Esanders merged a task: T255131: Lede section edit broken on some pages.

Esanders mentioned this in T255131: Lede section edit broken on some pages.

Esanders removed projects: User-Ryasmeen, Verified, VisualEditor (Current work).

Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 11 2020, 12:05 PM

This has regressed.

It looks like in VisualEditorOverlay#scrollToLeadParagraph we have a section of (string)"0" but we are only checking for (number)0, so the identifyLeadParagraph code isn't running.

CC @matmarex who was working on the section code recently.

According to https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/585029/ we should always treat sections as strings, so it looks like this case got missed.

Change 604689 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Follow-up I8373a7a: Always treat sections as strings

https://gerrit.wikimedia.org/r/604689

gerritbot added a project: Patch-For-Review.Jun 11 2020, 12:24 PM

Change 604689 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Follow-up I8373a7a: Always treat sections as strings

https://gerrit.wikimedia.org/r/604689

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2020, 9:10 PM

Thanks, I must have missed that line.

matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).Jun 12 2020, 4:47 PM

matmarex moved this task from Needs Discussion / Investigation to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

matmarex added a project: Editing QA.

JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.Jun 16 2020, 3:56 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Jul 2 2020, 7:31 PM