Page MenuHomePhabricator
Create Task
Maniphest T235222

Scroll-past-infobox not working on many pages
Closed, ResolvedPublic
Actions

Description

Probably due to invisible templates taking on a rendering, e.g.:

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masteridentifyLeadParagraph: Ignore invisible nodes, slugs and whitespace

Event Timeline

Esanders created this task.Oct 10 2019, 9:37 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 10 2019, 9:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 10 2019, 10:16 PM

Change 542246 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] identifyLeadParagraph: Ignore invisible nodes, slugs and whitespace

https://gerrit.wikimedia.org/r/542246

gerritbot added a comment.Oct 16 2019, 9:33 PM

Change 542246 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] identifyLeadParagraph: Ignore invisible nodes, slugs and whitespace

https://gerrit.wikimedia.org/r/542246

Ryasmeen added subscribers: ReleaseTaggerBot, Ryasmeen.Oct 17 2019, 6:54 PM

@matmarex: This is not yet on en.wiki right? Why did @ReleaseTaggerBot not tag this? 😕

matmarex added a comment.Oct 17 2019, 8:38 PM

It's not on en.wiki yet, it should be included in the next week's train deployment. No idea about ReleaseTaggerBot.

Ryasmeen added a comment.Oct 22 2019, 6:24 PM

Okay, checked it for the listed articles on en.wiki, scroll is now moving past the infobox for those articles.

Ryasmeen edited projects, added Verified; removed Editing QA.Oct 22 2019, 6:25 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Tue, Jan 21, 2:04 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptTue, Jan 21, 2:04 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL