Page MenuHomePhabricator

Toolforge: updatetools service is failing
Closed, DuplicatePublic

Description

The updatetools service in Toolforge seems to be failing.

I found the following log messages:

Oct 11 10:16:21 tools-sge-services-03 systemd[1]: [/lib/systemd/system/updatetools.service:17] Invalid user/group name or numeric ID, ignoring: tools.admin
Oct 11 10:16:21 tools-sge-services-03 systemd[1]: [/lib/systemd/system/updatetools.service:18] Invalid user/group name or numeric ID, ignoring: tools.admin

however:

aborrero@tools-sge-services-03:~$ id tools.admin
uid=51051(tools.admin) gid=51051(tools.admin) groups=51051(tools.admin),53060(tools.gridengine-status),53937(tools.trusty-tools),53856(tools.vuln-checker),53063(tools.admin-beta),53935(tools.sge-jobs),52513(tools.cdnjs),52682(tools.dpkg),52468(tools.repo)

Could it be simply that systemd v232 doesn't like the dot in the user name string?

Event Timeline

systemd of any version thinks that "." is invalid in a username, by design https://github.com/systemd/systemd/blob/100d5f6ee6ec53ecc20160cd4d6656cacf57db4f/src/basic/user-util.c#L588

Did we miss another thing? 😟
I thought we found all of these a while back, but apparently not.

I thought we found all of these a while back, but apparently not.

Duplicate of T229261: Database table backing https://tools.wmflabs.org/admin/tools listing not being updated properly. I have the updatetools code that I improved running as a cron job from the admin tool now, but apparently I forgot to actually clean up the broken systemd job (and put the updatetools code into some other git repo for the admin tool).