The PHPUtils::jsSort routine was added in e8c1f1c9c6a40acdba9a132bbb643eccde636fcc to make parserTests output compatible between Parsoid/JS and Parsoid/PHP for data-mw attributes. Once Parsoid/JS is retired, we should remove this routine and rewrite the parserTests to use the Parsoid/PHP order (which is actually closer to wikitext source order).
Description
Description
Details
Details
Related Gerrit Patches:
| mediawiki/services/parsoid : master | Remove PHPUtils::jsSort call from TemplateHandler and correct tests |
Related Objects
Related Objects
- Mentioned In
- T240054: Move top level namespace from Parsoid to Wikimedia\Parsoid
T204618: Permit aria-hidden="true" in Sanitizer
T238845: Call to a member function serialize() on null
T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers)
T242746: Update ParsoidExtensionAPI to be a coherent and functional extension API to aid extension implementations
T244413: PHP Warning: Use of undefined constant PAGE_UNAVAILABLE - assumed 'PAGE_UNAVAILABLE' (this will throw an Error in a future version of PHP)
T244412: PHP Warning: A non-numeric value encountered - Mentioned Here
- T204618: Permit aria-hidden="true" in Sanitizer
T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers)
T238845: Call to a member function serialize() on null
T240054: Move top level namespace from Parsoid to Wikimedia\Parsoid
T242746: Update ParsoidExtensionAPI to be a coherent and functional extension API to aid extension implementations
T244412: PHP Warning: A non-numeric value encountered
T244413: PHP Warning: Use of undefined constant PAGE_UNAVAILABLE - assumed 'PAGE_UNAVAILABLE' (this will throw an Error in a future version of PHP)
rGPAR612106d2f3a0: Use extension config option for html2wt formatting of extension tags
rGPARe8c1f1c9c6a4: Match JS order for data-mw corresponding to template parameters
Event Timeline
Comment Actions
Change 566379 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] WIP remove jsSort from PHPUtils and and use ksort and correct tests
Comment Actions
Change 566379 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove PHPUtils::jsSort call from TemplateHandler and correct tests