Remove PHPUtils::jsSort routine (or make it no-op) once Parsoid/JS is retired
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Oct 11 2019, 3:11 PM

Description

The PHPUtils::jsSort routine was added in e8c1f1c9c6a40acdba9a132bbb643eccde636fcc to make parserTests output compatible between Parsoid/JS and Parsoid/PHP for data-mw attributes. Once Parsoid/JS is retired, we should remove this routine and rewrite the parserTests to use the Parsoid/PHP order (which is actually closer to wikitext source order).

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/services/parsoid	master	+2 -32	Remove PHPUtils::jsSort call from TemplateHandler and correct tests

Customize query in gerrit

Related Objects

Mentioned In: T240054: Move top level namespace from Parsoid to Wikimedia\Parsoid
T204618: Permit aria-hidden="true" in Sanitizer
T238845: Call to a member function serialize() on null
T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers)
T242746: Update ParsoidExtensionAPI to be a coherent and functional extension API to aid extension implementations
T244413: PHP Warning: Use of undefined constant PAGE_UNAVAILABLE - assumed 'PAGE_UNAVAILABLE' (this will throw an Error in a future version of PHP)
T244412: PHP Warning: A non-numeric value encountered
Mentioned Here: T204618: Permit aria-hidden="true" in Sanitizer
T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers)
T238845: Call to a member function serialize() on null
T240054: Move top level namespace from Parsoid to Wikimedia\Parsoid
T242746: Update ParsoidExtensionAPI to be a coherent and functional extension API to aid extension implementations
T244412: PHP Warning: A non-numeric value encountered
T244413: PHP Warning: Use of undefined constant PAGE_UNAVAILABLE - assumed 'PAGE_UNAVAILABLE' (this will throw an Error in a future version of PHP)
rGPAR612106d2f3a0: Use extension config option for html2wt formatting of extension tags
rGPARe8c1f1c9c6a4: Match JS order for data-mw corresponding to template parameters

Event Timeline

cscott created this task.Oct 11 2019, 3:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2019, 3:11 PM

cscott edited projects, added Parsoid-PHP; removed Parsoid.Oct 11 2019, 3:12 PM

cscott moved this task from Backlog to Porting Tech Debt Redressal on the Parsoid-PHP board.

ssastry triaged this task as Medium priority.Oct 24 2019, 8:29 PM

Sbailey claimed this task.Jan 21 2020, 7:56 PM

Change 566379 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] WIP remove jsSort from PHPUtils and and use ksort and correct tests

https://gerrit.wikimedia.org/r/566379

gerritbot added a project: Patch-For-Review.Jan 21 2020, 11:07 PM

Change 566379 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove PHPUtils::jsSort call from TemplateHandler and correct tests

https://gerrit.wikimedia.org/r/566379

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2020, 9:10 PM

Arlolra closed this task as Resolved.Jan 23 2020, 9:35 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-10T21:43:15Z] <arlolra> Updated Parsoid to 612106d2 (T244412, T244413, T242746, T235273, T235307, T238845, T204618, T240054)

Stashbot mentioned this in T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers).Feb 10 2020, 9:43 PM

Stashbot mentioned this in T238845: Call to a member function serialize() on null.

Stashbot mentioned this in T204618: Permit aria-hidden="true" in Sanitizer.

Stashbot mentioned this in T240054: Move top level namespace from Parsoid to Wikimedia\Parsoid.

Remove PHPUtils::jsSort routine (or make it no-op) once Parsoid/JS is retiredClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Remove PHPUtils::jsSort routine (or make it no-op) once Parsoid/JS is retired
Closed, ResolvedPublic
Actions