Page MenuHomePhabricator
Create Task
Maniphest T235326

Wikibase PHPUnit tests are broken
Closed, ResolvedPublic
Actions

Description

Seen e.g. in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/24311/console:

PHP Fatal error: Declaration of Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseLibraryTestCase::tearDown() must be compatible with Scribunto_LuaEngineTestBase::tearDown(): void in /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php on line 224

That's because we're upgrading to PHPCS 28.0.0, which forces you to add :void typehints to setUp and tearDown (because they were added in PHPUnit 8). Scribunto was already upgraded, hence it now has the typehints. But Wikibase extends some of those Scribunto classes without using typehints, and hence it broke.

A quick way to unbreak the world would be to upgrade wikibase-codesniffer to use mediawiki-codesniffer 28.0.0, then run phpcbf.

Details

SubjectRepoBranchLines +/-
Upgrade wikibase codesniffer to 1.0.0mediawiki/extensions/WikibaseLexemeCirrusSearchmaster+6 -4
Upgrade wikibase codesniffer to 1.0.0mediawiki/extensions/WikibaseCirrusSearchmaster+11 -8
Upgrade codesniffer to 1.0.0mediawiki/extensions/WikibaseMediaInfomaster+12 -7
Upgrade wikibase codesniffer to 1.0.0mediawiki/extensions/WikibaseQualityConstraintsmaster+51 -52
Upgrade wikibase codesniffer to 1.0.0mediawiki/extensions/Wikibasemaster+352 -334
Upgrade wikibase codesniffer to 1.0.0mediawiki/extensions/WikibaseLexememaster+46 -42
Unbreak wikibase testsmediawiki/extensions/Wikibasemaster+4 -4
Upgrade phpcs to 28.0.0mediawiki/extensions/PropertySuggestermaster+15 -26
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Oct 12 2019, 10:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2019, 10:45 AM
Daimona triaged this task as High priority.Oct 12 2019, 10:45 AM
Daimona added subscribers: thiemowmde, Lucas_Werkmeister_WMDE, Ladsgroup.Oct 12 2019, 1:10 PM

https://github.com/wmde/WikibaseCodeSniffer/pull/54

Ladsgroup added a comment.Oct 12 2019, 1:31 PM
In T235326#5569704, @Daimona wrote:

https://github.com/wmde/WikibaseCodeSniffer/pull/54

Merged, let me know when you make the patch in wikibase repos

Daimona added a comment.Oct 12 2019, 1:36 PM
In T235326#5569733, @Ladsgroup wrote:
In T235326#5569704, @Daimona wrote:

https://github.com/wmde/WikibaseCodeSniffer/pull/54

Merged, let me know when you make the patch in wikibase repos

Thanks! I can do it now, if you release a new version.

Ladsgroup added a comment.Oct 12 2019, 1:43 PM

Can you make a pull request? It looks like a breaking change, a major version bump is needed

Daimona added a comment.Oct 12 2019, 1:49 PM
In T235326#5569744, @Ladsgroup wrote:

Can you make a pull request? It looks like a breaking change, a major version bump is needed

https://github.com/wmde/WikibaseCodeSniffer/pull/55 is for release notes etc. I cannot actually tag a new version by myself.

Ladsgroup added a comment.Oct 12 2019, 3:15 PM

1.0.0 supposed to be released now. I don't know if packagist picked it up or not.

Daimona added a comment.Oct 12 2019, 3:32 PM
In T235326#5569844, @Ladsgroup wrote:

1.0.0 supposed to be released now. I don't know if packagist picked it up or not.

Let's hope so. I'm starting with Wikibase-related repos, and doing Wikibase itself last, for the same reason about signatures.

gerritbot added a comment.Oct 12 2019, 3:34 PM

Change 542680 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseMediaInfo@master] Upgrade codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542680

gerritbot added a project: Patch-For-Review.Oct 12 2019, 3:34 PM

Change 542679 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseQualityConstraints@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542679

gerritbot added a comment.Oct 12 2019, 3:37 PM

Change 542681 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542681

gerritbot added a comment.Oct 12 2019, 3:38 PM

Change 542682 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseLexeme@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542682

gerritbot added a comment.Oct 12 2019, 3:39 PM

Change 542683 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseCirrusSearch@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542683

gerritbot added a comment.Oct 12 2019, 3:43 PM

Change 542684 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Wikibase@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542684

Daimona claimed this task.Oct 12 2019, 3:44 PM
Daimona added a comment.Oct 12 2019, 4:00 PM
In T235326#5569865, @Daimona wrote:
In T235326#5569844, @Ladsgroup wrote:

1.0.0 supposed to be released now. I don't know if packagist picked it up or not.

Let's hope so. I'm starting with Wikibase-related repos, and doing Wikibase itself last, for the same reason about signatures.

Everything's on gerrit now, but instead, we should start with Wikibase itself. The tests are broken for related repos, too.

gerritbot added a comment.Oct 12 2019, 5:45 PM

Change 542695 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/PropertySuggester@master] Upgrade phpcs to 28.0.0

https://gerrit.wikimedia.org/r/542695

gerritbot added a comment.Oct 12 2019, 6:12 PM

Change 542699 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Wikibase@master] Unbreak wikibase tests

https://gerrit.wikimedia.org/r/542699

gerritbot added a comment.Oct 12 2019, 7:21 PM

Change 542699 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Unbreak wikibase tests

https://gerrit.wikimedia.org/r/542699

gerritbot added a comment.Oct 12 2019, 7:21 PM

Change 542695 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Upgrade phpcs to 28.0.0

https://gerrit.wikimedia.org/r/542695

Daimona mentioned this in rEPSc7bb5102938d: Upgrade phpcs to 28.0.0.Oct 12 2019, 7:25 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 12 2019, 8:00 PM
gerritbot added a comment.Oct 13 2019, 4:08 PM

Change 542682 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542682

gerritbot added a comment.Oct 13 2019, 4:09 PM

Change 542684 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542684

gerritbot added a comment.Oct 14 2019, 6:25 AM

Change 542679 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542679

Daimona mentioned this in rEBQCd3dd3361aa2b: Upgrade wikibase codesniffer to 1.0.0.Oct 14 2019, 6:50 AM
gerritbot added a comment.Oct 14 2019, 9:53 AM

Change 542680 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Upgrade codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542680

gerritbot added a comment.Oct 15 2019, 7:30 AM

Change 542683 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542683

Daimona mentioned this in rEWCS86f8e5c75ec3: Upgrade wikibase codesniffer to 1.0.0.Oct 15 2019, 7:50 AM
gerritbot added a comment.Oct 15 2019, 9:54 AM

Change 542681 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Upgrade wikibase codesniffer to 1.0.0

https://gerrit.wikimedia.org/r/542681

Daimona mentioned this in rEWLCe3b1bd93fd7d: Upgrade wikibase codesniffer to 1.0.0.Oct 15 2019, 9:58 AM
Daimona closed this task as Resolved.Oct 15 2019, 11:19 AM
Daimona removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL