Page MenuHomePhabricator
Create Task
Maniphest T235334

ErrorException from line 596 of /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQueryBase.php: PHP Notice: Undefined property: stdClass::$page_namespace
Closed, DuplicatePublic
Actions

Description

As of 14:25UTC 2019-10-12, Mediawiki is logging a high rate (~2.7k/minute errors) of this:

ErrorException from line 596 of /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQueryBase.php: PHP Notice: Undefined property: stdClass::$page_namespace

Errors are almost entirely enwiki, and look to occur bucketed at 5-minute intervals.

https://logstash.wikimedia.org/goto/68696e23e000f401450e528e03fcdffe

Sample Logstash document: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-mediawiki-2019.10.12/mediawiki?id=AW3AnCXDx3rdj6D8OARR&_g=h@44136fa

#0 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQueryBase.php(596): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQueryBacklinksprop.php(289): ApiQueryBase->executeGenderCacheFromResultWrapper(Wikimedia\Rdbms\ResultWrapper, string)
#2 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQueryBacklinksprop.php(83): ApiQueryBacklinksprop->run()
#3 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQuery.php(255): ApiQueryBacklinksprop->execute()
#4 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiMain.php(1588): ApiQuery->execute()
#5 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiMain.php(537): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiMain.php(508): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.35.0-wmf.1/api.php(83): ApiMain->execute()
#8 /srv/mediawiki/w/api.php(3): require(string)
#9 {main}

Details

SubjectRepoBranchLines +/-
Revert "Fill GenderCache for used pages in action=query&prop=fileusage"mediawiki/corewmf/1.35.0-wmf.1+0 -39
Customize query in gerrit

Related Objects

Event Timeline

CDanis created this task.Oct 12 2019, 3:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2019, 3:45 PM
Reedy added a project: MediaWiki-Action-API.Oct 12 2019, 3:50 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptOct 12 2019, 3:50 PM
Reedy updated the task description. (Show Details)Oct 12 2019, 3:52 PM
Reedy added subscribers: Umherirrender, Reedy.Oct 12 2019, 3:58 PM

I think https://github.com/wikimedia/mediawiki/commit/a8525d7201dada88f3117142fe1919d0b9b80d4e is to blame

Reedy added a project: MW-1.34-release.Oct 12 2019, 3:59 PM
gerritbot added a comment.Oct 12 2019, 4:00 PM

Change 542686 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Revert "Fill GenderCache for used pages in action=query&prop=fileusage"

https://gerrit.wikimedia.org/r/542686

gerritbot added a project: Patch-For-Review.Oct 12 2019, 4:00 PM

Change 542687 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@wmf/1.35.0-wmf.1] Revert "Fill GenderCache for used pages in action=query&prop=fileusage"

https://gerrit.wikimedia.org/r/542687

Reedy added a comment.Oct 12 2019, 4:01 PM

Reverting out of 1.35.0-wmf.1 (for now), due to ~240K errors in 90 minutes on enwiki

Umherirrender added a comment.Oct 12 2019, 4:09 PM

Already filled as T235316

gerritbot added a comment.Oct 12 2019, 4:13 PM

Change 542687 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.1] Revert "Fill GenderCache for used pages in action=query&prop=fileusage"

https://gerrit.wikimedia.org/r/542687

Stashbot added a comment.Oct 12 2019, 4:15 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-12T16:15:36Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.1/includes/api/ApiQueryBacklinksprop.php: T235334 (duration: 00m 56s)

Stashbot added a comment.Oct 12 2019, 4:16 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-12T16:16:42Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.1/includes/api/ApiQueryBase.php: T235334 (duration: 00m 51s)

Krinkle closed this task as a duplicate of T235316: PHP Notice: Undefined property: stdClass::$page_namespace.Oct 12 2019, 4:47 PM
Krinkle mentioned this in T235316: PHP Notice: Undefined property: stdClass::$page_namespace.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 12 2019, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL