Page MenuHomePhabricator

Remove polyfill's from DonationInterface vendor
Closed, ResolvedPublic

Description

I noticed that DonationInterface's vendor has polyfill-php54, polyfill-php55, polyfill-ctype and polyfill-mbstring

You definitely don't need the first two (even on MW 1.31 you need newer PHP), and you almost certainly don't need the other two

If you add something like the below to composer.json:

	"replace": {
		"symfony/polyfill-ctype": "1.99",
		"symfony/polyfill-mbstring": "1.99",
		"symfony/polyfill-php54": "1.99"
		"symfony/polyfill-php55": "1.99"
	},

And then run composer update --no-dev, it'll remove them

Event Timeline

Change 730390 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/core@fundraising/REL1_35] Remove unneeded polyfills

https://gerrit.wikimedia.org/r/730390

Change 730390 merged by jenkins-bot:

[mediawiki/core@fundraising/REL1_35] Remove unused polyfills

https://gerrit.wikimedia.org/r/730390

Ejegg claimed this task.
Ejegg subscribed.

Added up at the root of our mw branch, as we're not using separate vendor directories inside the extensions any more.