They are crime against humanity, just like the browser they're made for. Usage appears minimal after this commit is merged, so the parameter $condition could be deprecated.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Deprecate IE conditionals in OutputPage::addStyle() method | mediawiki/core | master | +5 -2 |
Event Timeline
Comment Actions
Change 552956 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate IE conditionals in OutputPage::addStyle() method
Comment Actions
Change 552956 abandoned by Ammarpad:
Deprecate IE conditionals in OutputPage::addStyle() method
Comment Actions
Takes no effort to support, is part of a legacy method of queueing raw stylesheets. So long as we facilitate an abstravted way of doing that within OutputPage, it seems fair to also give it this widely known capability.
Perhaps file a new task (or repurpose this one?) for exploring uses of addStyle() more generally and consider deprecating that method. In favour of migrating remaining callers to use ResourceLoader, or using the more low-level OutputPage::addLink, or even lower-evel OutputPage::addHeadItem with Html::element(). The abstraction provides very little convenience anyway, but IE conditionals seems like actually the only noteworthy convenience capability it does have today.