messagegroups API fails when mgformat=tree
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to reproduce:
Try to visit

Expected result:
Output similar to using mgformat=flat

Actual result:

{
    "error": {
        "code": "internal_api_error_Error",
        "info": "[XaLDnQpAEMUAAANRb2IAAACW] Caught exception of type Error",
        "errorclass": "Error"
    },
    "servedby": "mw1276"
}

Details

Request ID: XaLDhApAAEcAAGfOeUQAAABY
Request URL: https://www.wikidata.org/w/api.php?action=query&format=json&meta=messagegroups&mgfilter=page-User%3ADannyS712%2Fsandbox&mgformat=tree

Stack Trace

#0 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQuery.php(255): ApiQueryMessageGroups->execute()
#1 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiMain.php(1588): ApiQuery->execute()
#2 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiMain.php(537): ApiMain->executeAction()
#3 /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiMain.php(508): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/php-1.35.0-wmf.1/api.php(83): ApiMain->execute()
#5 /srv/mediawiki/w/api.php(3): require(string)
#6 {main}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Unbreak meta=messagegroups with mgformat=tree	mediawiki/extensions/Translate	master	+5 -3

Customize query in gerrit

Event Timeline

DannyS712 created this task.Oct 13 2019, 6:29 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 13 2019, 6:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 edited Stack Trace. (Show Details)Oct 13 2019, 6:29 AM

DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.

Nikerabbit edited Stack Trace. (Show Details)Oct 13 2019, 8:44 AM

That's a weird stacktrace... anyway the relevant details are:

/srv/mediawiki/php-1.35.0-wmf.1/extensions/Translate/api/ApiQueryMessageGroups.php:90
Call to a member function getId() on array

That is https://gerrit.wikimedia.org/g/mediawiki/extensions/Translate/+/38b0845ec2cb0668fcdcdd1fde1c45097e928c57/api/ApiQueryMessageGroups.php#90

Only happens when mgfilter is used. Workaround is to not use tree format when using mgfilter.

Krinkle moved this task from Untriaged to Jun 2019 / 1.34.wmf.8+ on the Wikimedia-production-error board.Oct 19 2019, 9:06 PM

Change 554616 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Translate@master] Unbreak meta=messagegroups with mgformat=tree

https://gerrit.wikimedia.org/r/554616

gerritbot added a project: Patch-For-Review.Dec 4 2019, 8:15 PM

Change 554616 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Unbreak meta=messagegroups with mgformat=tree

https://gerrit.wikimedia.org/r/554616

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2019, 11:10 AM

Nikerabbit closed this task as Resolved.Dec 16 2019, 11:16 AM

Nikerabbit claimed this task.

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 16 2019, 12:01 PM

DannyS712 moved this task from Reports to Resolved tasks (others) on the User-DannyS712 board.Dec 26 2019, 6:05 AM