Page MenuHomePhabricator
Create Task
Maniphest T235381

Release taint-check 2.1.0
Closed, ResolvedPublic
Actions

Description

Split from T227406. It should include the following patches:

  • r507849 - Only touches caused-by lines
  • r507981 - Handles closures
  • r507986 - Handles variables used by closures
  • r508082 - Code cleanup
  • r508085 - Visits AST_EMPTY, straightforward
  • r508124 - Explicitly mark as INAPPLICABLE a few node kinds, + visit exit() and clone
  • r522077 - Just some debug logging
  • r522140 - Switch back to phpunit for IDEs etc.

No relevant changes for consumers in this release.

After releasing, cherry-pick and abandon any remaining patch in the 2.x release and start working on master again.

Related Objects
Search...

Event Timeline

Daimona created this task.Oct 13 2019, 2:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2019, 2:35 PM
Daimona mentioned this in T227406: Release taint-check 2.0.2 and 2.1.0.Oct 13 2019, 2:36 PM
Daimona updated the task description. (Show Details)
Daimona mentioned this in T235383: Release taint-check 3.0.0.Oct 13 2019, 2:43 PM
Daimona added a parent task: T235383: Release taint-check 3.0.0.
Daimona updated the task description. (Show Details)Oct 15 2019, 5:09 PM
Jdforrester-WMF updated the task description. (Show Details)Oct 15 2019, 5:24 PM
Jdforrester-WMF subscribed.
Jdforrester-WMF added a comment.Oct 15 2019, 5:27 PM

Time to merge 2.x into master and make a release?

sbassett triaged this task as Medium priority.Oct 15 2019, 6:50 PM
sbassett subscribed.

Time to merge 2.x into master and make a release?

A good chunk of these were just merged, but if we're comfortable with the stability, we could do a 2.1.0 release soon and drop the 2.x dev branch. I'd guess that'd be the last 2.x release given T235383, aside from perhaps security/maintenance releases?

Daimona added a comment.Oct 16 2019, 9:30 AM
In T235381#5576310, @Jdforrester-WMF wrote:

Time to merge 2.x into master and make a release?

Yes!

In T235381#5576695, @sbassett wrote:

A good chunk of these were just merged, but if we're comfortable with the stability, we could do a 2.1.0 release soon and drop the 2.x dev branch.

Yes, I'm pretty confident. Those are mostly cleanup/small changes, mainly leftovers from the past phan upgrade. I'm going to release 2.1.0, but I think we don't have to start using it in all repos. We can wait for 3.0.0 for the big bump.

I'd guess that'd be the last 2.x release given T235383, aside from perhaps security/maintenance releases?

Exactly. Note, I won't drop the branch altogether, I'll just cherry-pick and abandon whatever is left in it.

Daimona closed this task as Resolved.Oct 16 2019, 9:41 AM
Daimona claimed this task.

Done just now: https://gerrit.wikimedia.org/g/mediawiki/tools/phan/SecurityCheckPlugin/+/refs/tags/2.1.0

sbassett awarded a token.Oct 16 2019, 5:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits