Page MenuHomePhabricator

Change “Add article description” icon, separator color & thickness
Closed, ResolvedPublic

Description

What is this all about?

  • All micro contribution opportunities should be consistently indicated with “+” iconography
  • Therefore, use “+” iconography for “Add article description” links in articles
  • Spacing/indentation should be aligned with “ADD IMAGE CAPTION” CTA’s on Android
  • Extra as you’re already here: change border thickness from 2sp to 1sp and use color_group_18 from theme guidelines page.

Visuals for Android

BeforeAfter
Screenshot_20191014-115255.png (2×1 px, 649 KB)
sev4-24.png (1×720 px, 929 KB)
Zeplin

Event Timeline

scblr added a subscriber: cmadeo.

@schoenbaechler this works for me although the all caps presentation is not something that we commonly use on iOS. Would it be possible for iOS to branch from Android and utilize the italics with sentence case?

@cmadeo

this works for me although the all caps presentation is not something that we commonly use on iOS. Would it be possible for iOS to branch from Android and utilize the italics with sentence case?

Yes, we should definitely use the default styles for that link type on iOS. Do you want to add an iOS visual to this task so it’s clear?

The style and label of the ADD ARTICLE DESCRIPTION CTA seems to be reverted on (Android) production. Any idea why @JoeWalsh Thx!

Moving this one back as the changes seem to be reverted in the latest version of the Android app:

2020-07-31 23.43.48.png (2×1 px, 337 KB)

I made a patch recently to the mobile-html endpoint that should fix that presentation. I'm guessing it's a matter of clearing the cache that will allow the updated CSS to be served up. Is this correct, @Mholloway?

It's not yet deployed. I'll do so at the next available opportunity this afternoon.

I've made a note on the agenda for our upcoming team retrospective to talk about a SOP for service deployments.

The change is now deployed (and the old CSS purged from cache), and I've verified it in the app.

Mholloway claimed this task.

Hey @Mholloway @Dbrant, thx for taking a look at it.

I just noticed some issues i while doing other QA work:

01) Inconsistent CTA’s in the latest Android Alpha (ADD TITLE DESCRIPTION vs ADD ARTICLE DESCRIPTION):

2020-08-10 14.05.30.png (2×1 px, 255 KB)
2020-08-10 14.06.35.png (2×1 px, 1 MB)

→ A caching issue? Deleted the cache but it was still not updated.

02) Also, the font definitions of the CTA on Android should be Roboto-Medium, 14sp to align it with the ADD IMAGE CAPTION CTA from the article header.

03) In addition, the touch target spacing is insufficient and must be at least 48dp. Otherwise it’s hard to tap.

Could you look into this? Thx!

Yes, the instance of a page with ADD TITLE DESCRIPTION that you found was almost certainly lingering in server-side cache. I see the page now has a description.