Page MenuHomePhabricator

FRUEC: For CentralNotice impression counts, take into account client-side sample rate
Open, Needs TriagePublic2 Story Points

Description

DjangoBannerStats (the legacy ingress script that FRUEC replaces) does not take into account client-side sample rate when counting banner impressions for aggregation in the pgehres database.

Since Fundraising campaigns always use a 100% client-side sample rate for the old data pipeline (calls to the beacon/impression endpoint), counts in the bannerimpressions table are accurate for Fundraising campaigns. However, they are inaccurate for most community campaigns.

FRUEC follows the legacy system in not taking client-side sample rate into account. However, this will make it difficult to compare data between the new and old pipelines unless the client-side sample rate is set to 1 on the new data pipeline. But current rollout plans have been to gradually raise the new data pipeline client-side sample rate bit by bit as we go.

If we make FRUEC take into account the client-side sample rate, we'll be able to compare data from the two pipelines for Fundraising campaigns. And, once the new pipeline is switched to production, we'll also have accurate data across all campaigns, not just Fundraising ones. So, let's do that!

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2019, 4:25 AM
AndyRussG renamed this task from FRUEC: For CentralNotice impression counts, take into account client-side sample rate. to FRUEC: For CentralNotice impression counts, take into account client-side sample rate.Oct 15 2019, 4:43 AM