Page MenuHomePhabricator

Parsoid/JS / RESTBase ETag harmonisation
Closed, ResolvedPublic

Description

RESTBase clients (most notably VE) rely on Etags being of the form {revid}/{timeuuid}. However, Parsoid/JS emits Express-generated ETags which vastly differ. Parsoid/JS should emit ETags in the same form for compatibility in cases where clients use Parsoid directly (e.g. private wikis).

See also T235460: Parsoid/PHP does not emit ETags.

Details

Related Gerrit Patches:
mediawiki/services/parsoid : masterETag harmonisation

Event Timeline

mobrovac triaged this task as High priority.Oct 15 2019, 4:33 AM
mobrovac created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2019, 4:33 AM

For context, this came out of code review discussion on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/543012 – I don't think this is a problem for VE right now.

(It might make sense to keep the etag formats different, so that we can notice if we ever get etags from the wrong source; if you want to have a consistent format, then maybe using a suffix or something.)

Change 544264 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] ETag harmonisation

https://gerrit.wikimedia.org/r/544264

Change 544264 merged by jenkins-bot:
[mediawiki/services/parsoid@master] ETag harmonisation

https://gerrit.wikimedia.org/r/544264

Arlolra closed this task as Resolved.Oct 21 2019, 3:12 PM
Arlolra claimed this task.