Page MenuHomePhabricator

Ensure constructed i18n messages document all possible used strings in comments in JS
Closed, ResolvedPublic

Description

This can be done with a custom eslint rule.

The standard format proposed in T224429 is something along these lines:

// The following messages can be used here:
// * msg:visualeditor-table-format-data
// * msg:visualeditor-table-format-header
mw.msg( 'visualeditor-table-format-' + style );

Event Timeline

Esanders created this task.Oct 15 2019, 1:17 PM

Change 543146 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Create a plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/543146

The above patch ensures there are at least 2 "msg:..." comments before any constructed messages.

Anomie removed a subscriber: Anomie.Oct 15 2019, 3:19 PM

Change 543146 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Use plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/543146

Change 544970 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Use plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/544970

Change 544970 merged by jenkins-bot:
[mediawiki/core@master] Use plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/544970

Change 545261 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c506a6aa)

https://gerrit.wikimedia.org/r/545261

Change 545261 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c506a6aa)

https://gerrit.wikimedia.org/r/545261

Jdforrester-WMF closed this task as Resolved.Mar 20 2020, 5:59 PM
Jdforrester-WMF assigned this task to Esanders.

Done enough.