Ensure constructed i18n messages document all possible used strings in comments in JS
Closed, ResolvedPublic
Actions

Description

This can be done with a custom eslint rule.

The standard format proposed in T224429 is something along these lines:

// The following messages can be used here:
// * msg:visualeditor-table-format-data
// * msg:visualeditor-table-format-header
mw.msg( 'visualeditor-table-format-' + style );

Details

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (6c506a6aa)	mediawiki/extensions/VisualEditor	master	+1 -1
Use plugin to ensure all message keys are documented	mediawiki/core	master	+102 -23
Use plugin to ensure all message keys are documented	VisualEditor/VisualEditor	master	+11 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T224429 Hunt and remove unused i18n messages in mediawiki core
		Resolved		Esanders	T235502 Ensure constructed i18n messages document all possible used strings in comments in JS

Event Timeline

Esanders created this task.Oct 15 2019, 1:17 PM

Change 543146 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Create a plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/543146

gerritbot added a project: Patch-For-Review.Oct 15 2019, 1:37 PM

The above patch ensures there are at least 2 "msg:..." comments before any constructed messages.

Jdforrester-WMF added projects: Continuous-Integration-Infrastructure, Release-Engineering-Team (CI & Testing services).Oct 15 2019, 2:00 PM

Anomie unsubscribed.Oct 15 2019, 3:19 PM

Esanders mentioned this in T224429: Hunt and remove unused i18n messages in mediawiki core.Oct 15 2019, 4:53 PM

Change 543146 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Use plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/543146

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2019, 1:10 PM

Change 544970 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Use plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/544970

gerritbot added a project: Patch-For-Review.Oct 21 2019, 4:07 PM

Very nice.

Change 544970 merged by jenkins-bot:
[mediawiki/core@master] Use plugin to ensure all message keys are documented

https://gerrit.wikimedia.org/r/544970

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2019, 6:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 21 2019, 10:01 PM

Change 545261 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c506a6aa)

https://gerrit.wikimedia.org/r/545261

gerritbot added a project: Patch-For-Review.Oct 22 2019, 12:12 PM

Change 545261 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c506a6aa)

https://gerrit.wikimedia.org/r/545261

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2019, 1:10 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.4; 2019-10-29); removed MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 22 2019, 2:14 PM