Page MenuHomePhabricator

Support red border for fundraising feed cards
Open, HighPublic4 Estimate Story Points

Description

Also in-article banners if we are able to make them. Perhaps by creating a flag class - on for red border, off for no border.

Check with iOS as they are already using this.

Updated:
Red border setting from the iOS app:
https://github.com/wikimedia/wikipedia-ios/blob/69d797531e75240899ffa101da9dfe44b5d0382e/Wikipedia/Code/AnnouncementCollectionViewCell.swift#L238

2018 app fundraising announcements patch:
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mobileapps/+/473248/

wikifeeds (should push patch to this repo).
https://gerrit.wikimedia.org/r/#/q/project:mediawiki/services/wikifeeds

Event Timeline

Charlotte updated the task description. (Show Details)Oct 15 2019, 3:54 PM
LGoto updated the task description. (Show Details)Oct 15 2019, 5:05 PM
LGoto updated the task description. (Show Details)Oct 15 2019, 5:07 PM
Charlotte triaged this task as High priority.Oct 15 2019, 5:09 PM
Charlotte updated the task description. (Show Details)
Charlotte set the point value for this task to 4.

@schoenbaechler

Just found that the MaterialCardView (https://material.io/develop/android/components/material-card-view/) supports adding a border to the view, and it is how it looks like:


Using #d33 with 10 width.

Does it look good to you?

Thanks @cooltey, just checked the designs from last year’s fundraising season:

I think we can go with red30 (#b32424) instead of red50 (#d33), otherwise it looks good!

@schoenbaechler
Just found that the MaterialCardView (https://material.io/develop/android/components/material-card-view/) supports adding a border to the view

Well that's good news! Thanks for picking this up @cooltey

cooltey updated the task description. (Show Details)Oct 18 2019, 9:22 PM
cooltey updated the task description. (Show Details)Oct 18 2019, 10:01 PM
cooltey updated the task description. (Show Details)Oct 18 2019, 10:40 PM

Per T235652#5698593, I wasn’t able to check the Explore feed card yet.