Page MenuHomePhabricator

Export CI=true environment variable in Wikimedia CI
Closed, ResolvedPublic


The CI=true environment variable seems to be a semi-standard way of indicating a CI environment; it’s provided at least by Travis CI and GitLab CI. I think we should try setting it in Wikimedia CI as well.

One effect of this would be to silence the core-js postinstall script, which currently spams the logs of every Wikibase build with hundreds of lines of advertisements. (This can also be achieved with some other environment variables, but CI seems like the most reasonable one to me.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2019, 4:04 PM
hashar added a subscriber: hashar.

I guess we can set a global property in Jenkins via

We already have things such as FORCE_COLORS=1.

I've applied this. Let's see if it works?

Thanks, I’ll try to find some Wikibase build to trigger.

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 15 2019, 6:41 PM

Okay, has progressed far enough to see the effect of this build. There’s still some logspam due to the existence of the core-js postinstall script –

18:39:11 > core-js@3.2.1 postinstall /workspace/src/extensions/Wikibase/client/data-bridge/node_modules/@storybook/theming/node_modules/core-js
18:39:11 > node scripts/postinstall || echo "ignore"
18:39:12 > core-js@3.2.1 postinstall /workspace/src/extensions/Wikibase/client/data-bridge/node_modules/@storybook/client-logger/node_modules/core-js
18:39:12 > node scripts/postinstall || echo "ignore"

– but at least the bright coloured banner with the patreon link and whatnot is gone ^^