Page MenuHomePhabricator
Create Task
Maniphest T235560

Ensure that null is not returned in place of empty string
Closed, ResolvedPublic
Actions

Description

Description
For each route handler, if the Comment is present we should return the stored value even if the stored value is the empty string and not return "null" in place of an empty string.

Currently, we return "null" when an empty string is stored in the Comment table.

See this line for reference

Requirements:

  • All route handlers return empty string or "null" depending on the DB contents

Details

SubjectRepoBranchLines +/-
REST History and compare endpoints followups.mediawiki/coremaster+72 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

• WDoranWMF created this task.Oct 15 2019, 9:00 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 15 2019, 9:00 PM
• WDoranWMF triaged this task as Low priority.Oct 15 2019, 9:00 PM
• WDoranWMF moved this task from Backlog to Next Sprint on the Platform Team Workboards (Green) board.
• WDoranWMF moved this task from Next Sprint to Tasks Ready for Estimation on the Platform Team Workboards (Green) board.Oct 16 2019, 2:45 PM
• WDoranWMF updated the task description. (Show Details)Oct 16 2019, 2:48 PM
• Pchelolo added a comment.Oct 16 2019, 5:49 PM

Addressed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/542450 as well.

• WDoranWMF moved this task from Tasks Ready for Estimation to Waiting for Review on the Platform Team Workboards (Green) board.Oct 16 2019, 7:48 PM
gerritbot added a comment.Oct 16 2019, 10:52 PM

Change 542450 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] REST History and compare endpoints followups.

https://gerrit.wikimedia.org/r/542450

gerritbot added a project: Patch-For-Review.Oct 16 2019, 10:52 PM
gerritbot added a comment.Oct 16 2019, 11:30 PM

Change 542450 merged by jenkins-bot:
[mediawiki/core@master] REST History and compare endpoints followups.

https://gerrit.wikimedia.org/r/542450

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.3; 2019-10-22); removed MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 17 2019, 12:00 AM
apaskulin subscribed.Oct 17 2019, 3:39 PM

Updated the docs for the get page history and get revision endpoints as shown here. Let me know if this is incorrect or insufficient.

• Pchelolo moved this task from Waiting for Review to Done on the Platform Team Workboards (Green) board.Oct 18 2019, 7:07 PM
• eprodromou closed this task as Resolved.Oct 29 2019, 4:35 PM
• eprodromou claimed this task.

Looks correct.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits