Add minor edit count to REST API history count endpoint
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	BPirkle
	Oct 16 2019, 3:06 AM

Description

Per user story T234941: Curator gets minor edit count, we want to add a count of minor edits as one of the available count types on the existing /page/{title}/history/counts endpoint.

This is dependent on successful completion of T235572: Compose query for minor edit count, which will supply the necessary query.

T234941: Curator gets minor edit count contains the necessary specifications and details.

Requirements:

endpoint updated
Add integration test covering behaviour
Update docs: Add minor to the available types for Get page history counts. (Done)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add minor edit count to available REST API history counts	mediawiki/core	master	+53 -12

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T229661 Core REST API in MediaWiki
Resolved	• eprodromou	T231338 Page history API
Resolved	• eprodromou	T234941 Curator gets minor edit count
Resolved	BPirkle	T235587 Add minor edit count to REST API history count endpoint
Resolved	BPirkle	T235572 Compose query for minor edit count

Event Timeline

BPirkle created this task.Oct 16 2019, 3:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2019, 3:06 AM

The existing counts for this endpoint do not have unit tests. Should we add a unit test for the new count (and possibly the existing ones)? Or will we cover that with integration tests?

• WDoranWMF triaged this task as Medium priority.Oct 16 2019, 1:20 PM

• WDoranWMF moved this task from Backlog to Next Sprint on the Platform Team Workboards (Green) board.

Yep that makes sense to me. If we can add unit tests that would be good but the default should be integration tests.

• WDoranWMF updated the task description. (Show Details)Oct 16 2019, 2:31 PM

• WDoranWMF moved this task from Next Sprint to Tasks Ready for Estimation on the Platform Team Workboards (Green) board.Oct 16 2019, 2:45 PM

• WDoranWMF set the point value for this task to 2.Oct 16 2019, 7:40 PM

• WDoranWMF moved this task from Tasks Ready for Estimation to Ready on the Platform Team Workboards (Green) board.

• apaskulin updated the task description. (Show Details)Oct 16 2019, 10:00 PM

• apaskulin updated the task description. (Show Details)Oct 16 2019, 10:11 PM

BPirkle updated the task description. (Show Details)Oct 23 2019, 2:58 PM

BPirkle mentioned this in T234941: Curator gets minor edit count.Oct 23 2019, 3:01 PM

Change 545590 had a related patch set uploaded (by BPirkle; owner: BPirkle):
[mediawiki/core@master] Add minor edit count to available REST API history counts

https://gerrit.wikimedia.org/r/545590

gerritbot added a project: Patch-For-Review.Oct 23 2019, 3:08 PM

BPirkle claimed this task.Oct 23 2019, 3:10 PM

BPirkle moved this task from Ready to Doing on the Platform Team Workboards (Green) board.

BPirkle updated the task description. (Show Details)Oct 23 2019, 8:27 PM

• eprodromou added a parent task: T234941: Curator gets minor edit count.Oct 29 2019, 7:13 PM

• eprodromou added a subtask: T235572: Compose query for minor edit count.Nov 1 2019, 3:20 PM

Change 545590 merged by jenkins-bot:
[mediawiki/core@master] Add minor edit count to available REST API history counts

https://gerrit.wikimedia.org/r/545590

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 4 2019, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 9:11 PM

• eprodromou closed subtask T235572: Compose query for minor edit count as Resolved.Nov 5 2019, 3:53 PM