Page MenuHomePhabricator

AbuseFilter: When viewing an old revision of a filter, don't show abusefilter-edit-oldwarning if the user cannot edit the filter
Closed, ResolvedPublic

Description

Currently, anyone viewing, eg, https://en.wikipedia.org/wiki/Special:AbuseFilter/history/1/item/22300 (an old revision of the enwiki test filter) will see at the top and bottom the message from abusefilter-edit-oldwarning ("You are editing an old version of this filter...")

For users that do not have permission to edit the filter, this message is incorrect.

I propose adding a new message, abusefilter-view-oldwarning, which is instead shown to users who cannot edit the filter (includes the warning about statistics being for the current filter, doesn't include the warning about overwriting changes if you edit)

Thoughts?

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 16 2019, 5:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 added subscribers: Daimona, Huji.

@Daimona @Huji feedback requested on my proposed solution

DannyS712 triaged this task as Medium priority.Oct 16 2019, 5:50 AM

Fine by me, thanks!

Change 548431 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] When viewing old filter revisions, show abusefilter-view-oldwarning to users who cannot edit the filter

https://gerrit.wikimedia.org/r/548431

Change 548431 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] When viewing old filter revisions, show abusefilter-view-oldwarning to users who cannot edit the filter

https://gerrit.wikimedia.org/r/548431

Daimona closed this task as Resolved.Nov 12 2019, 6:59 PM
Daimona removed a project: Patch-For-Review.

Change 551818 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] i18n: Rename msg key for abusefilter-view-oldwarning

https://gerrit.wikimedia.org/r/551818

Change 551818 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] i18n: Rename msg key for abusefilter-view-oldwarning

https://gerrit.wikimedia.org/r/551818