Page MenuHomePhabricator
Create Task
Maniphest T235590

AbuseFilter: When viewing an old revision of a filter, don't show abusefilter-edit-oldwarning if the user cannot edit the filter
Closed, ResolvedPublic
Actions

Description

Currently, anyone viewing, eg, https://en.wikipedia.org/wiki/Special:AbuseFilter/history/1/item/22300 (an old revision of the enwiki test filter) will see at the top and bottom the message from abusefilter-edit-oldwarning ("You are editing an old version of this filter...")

For users that do not have permission to edit the filter, this message is incorrect.

I propose adding a new message, abusefilter-view-oldwarning, which is instead shown to users who cannot edit the filter (includes the warning about statistics being for the current filter, doesn't include the warning about overwriting changes if you edit)

Thoughts?

Details

SubjectRepoBranchLines +/-
i18n: Rename msg key for abusefilter-view-oldwarningmediawiki/extensions/AbuseFiltermaster+4 -4
When viewing old filter revisions, show `abusefilter-view-oldwarning` to users who cannot edit the filtermediawiki/extensions/AbuseFiltermaster+10 -3
Customize query in gerrit

Event Timeline

DannyS712 created this task.Oct 16 2019, 5:49 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 16 2019, 5:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Abuse Filter on the User-DannyS712 board.Oct 16 2019, 5:49 AM
DannyS712 added subscribers: Daimona, Huji.

@Daimona @Huji feedback requested on my proposed solution

DannyS712 triaged this task as Medium priority.Oct 16 2019, 5:50 AM
Daimona added a comment.Oct 17 2019, 9:23 AM

Fine by me, thanks!

gerritbot added a comment.Nov 4 2019, 6:26 PM

Change 548431 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] When viewing old filter revisions, show abusefilter-view-oldwarning to users who cannot edit the filter

https://gerrit.wikimedia.org/r/548431

gerritbot added a project: Patch-For-Review.Nov 4 2019, 6:26 PM
gerritbot added a comment.Nov 12 2019, 6:59 PM

Change 548431 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] When viewing old filter revisions, show abusefilter-view-oldwarning to users who cannot edit the filter

https://gerrit.wikimedia.org/r/548431

Daimona closed this task as Resolved.Nov 12 2019, 6:59 PM
Daimona removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 13 2019, 12:01 AM
gerritbot added a comment.Nov 19 2019, 1:34 PM

Change 551818 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] i18n: Rename msg key for abusefilter-view-oldwarning

https://gerrit.wikimedia.org/r/551818

gerritbot added a project: Patch-For-Review.Nov 19 2019, 1:34 PM
DannyS712 moved this task from Abuse Filter to Resolved tasks (Abuse Filter) on the User-DannyS712 board.Nov 26 2019, 11:54 AM
gerritbot added a comment.Dec 23 2019, 12:16 PM

Change 551818 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] i18n: Rename msg key for abusefilter-view-oldwarning

https://gerrit.wikimedia.org/r/551818

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.14; 2020-01-07); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Dec 23 2019, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 23 2019, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL