[4h] Share build and test script from package.json
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tarrow
	Oct 16 2019, 9:13 AM

Description

We reuse the test scripts identically compared to data-bridge and termbox apart from the names in the no-diff script.
E.g. https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/3fdc9580a77cc792777dbbfe7eb427871341f212/view/lib/wikibase-tainted-ref/package.json#L15

We should sure all the committed built files are tested for differences.

We should make sure all files resulting from the build are used and if needed tested. i.e. there shouldn't be files make that we then ignore.

We should look for an off the shelf solution to check that the above criteria are true.
If that isn't possible we should at least refactor the test:nodiff command to not be a a multiline bash script tucked in package.json (i.e. put it somewhere, parameterise it etc...)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Wikibase	master	+8 -1	TR: Bash script for diffing webpack

Customize query in gerrit

Event Timeline

Tarrow created this task.Oct 16 2019, 9:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2019, 9:13 AM

noarave edited projects, added Wikidata Tainted References; removed Wikidata-Tainted-References-Sprint3.Oct 24 2019, 1:07 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 24 2019, 1:07 PM

noarave moved this task from Backlog to For dev follow-up on the Wikidata Tainted References board.Nov 25 2019, 3:27 PM

• Addshore added a project: wdwb-tech.Dec 11 2019, 11:57 AM

Tarrow updated the task description. (Show Details)Jan 22 2020, 11:44 AM

WMDE-leszek updated the task description. (Show Details)Jan 22 2020, 11:44 AM

WMDE-leszek renamed this task from Share build and test script from package.json to [4h] Share build and test script from package.json.Jan 22 2020, 11:46 AM

WMDE-leszek moved this task from For dev follow-up to Ready to pick up on the Wikidata Tainted References board.

Tarrow claimed this task.Jan 29 2020, 3:24 PM

Tarrow edited projects, added Wikidata-Tainted-References-Sprint9; removed Wikidata Tainted References.

Tarrow moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint9 board.

WMDE-leszek added a project: Wikidata-Tainted-References-Sprint10.Feb 3 2020, 9:37 AM

WMDE-leszek moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint10 board.Feb 3 2020, 10:00 AM

Seems there isn't an obvious off the shelf solution for this. This closest thing I found was perhaps: https://github.com/smikula/webpack-bundle-diff or even https://github.com/mixer/webpack-bundle-compare but these are not at all for diffing to find any differences but more for comparison work.

I spent some time tying to build a small script to nicely automate this in JS. My plan was to try and use vue-cli to run a build progrmatically into e.g. /tmp:
inspect all the files in the output and diff each of those individually with what was committed.

I spent a little time trying to call vue-cli programatically but sadly this looks like a feature that will only be there in vue3. See: https://github.com/vuejs/vue-cli/issues/748

I'm now going to work on implementing basically the same thing in bash.

Tarrow moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint10 board.Feb 7 2020, 10:45 AM

Change 570876 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Bash script for diffing webpack

https://gerrit.wikimedia.org/r/570876

gerritbot added a project: Patch-For-Review.Feb 7 2020, 12:28 PM

hoo moved this task from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint10 board.Feb 7 2020, 12:35 PM

Change 570876 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Bash script for diffing webpack

https://gerrit.wikimedia.org/r/570876

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 7 2020, 2:00 PM

Lydia_Pintscher closed this task as Resolved.Feb 10 2020, 11:37 AM

Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Tainted-References-Sprint10 board.