header height too big
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Charlie_WMDE
	Oct 16 2019, 10:41 AM

Project Tags

Referenced Files

None

Subscribers

Description

Steps to Reproduce:
open bridge in beta

Actual Results:
the header (including buttons) has a height of 48px

Expected Results:
the header should have a height of 40px as well as the close and publish button

Note:
the Publish button height might. or not, have the incorrect height set.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	bridge: fix close button size	Lucas Werkmeister (WMDE)	mediawiki/extensions/Wikibase	master	+9 -9

Customize query in gerrit

Related Objects

Mentioned In: T235055: Create progressive disabled version of save button
Mentioned Here: T235624: close button size is not correct

Event Timeline

Charlie_WMDE created this task.Oct 16 2019, 10:41 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 16 2019, 10:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lucas_Werkmeister_WMDE renamed this task from header hight too big to header height too big.Oct 16 2019, 10:56 AM

Might by caused by the close button dimensions - T235624: close button size is not correct

Charlie_WMDE moved this task from Incoming to Ready to estimate on the Wikidata-Bridge board.Oct 17 2019, 11:45 AM

WMDE-leszek updated the task description. (Show Details)Oct 22 2019, 9:22 AM

Change 545211 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix close button size

https://gerrit.wikimedia.org/r/545211

gerritbot added a project: Patch-For-Review.Oct 22 2019, 9:22 AM

WMDE-leszek set the point value for this task to 1.Oct 22 2019, 9:23 AM

WMDE-leszek moved this task from Ready to estimate to Ready to pick up on the Wikidata-Bridge board.

Lucas_Werkmeister_WMDE mentioned this in T235055: Create progressive disabled version of save button.Oct 22 2019, 10:05 AM

Change 545211 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix close button size

https://gerrit.wikimedia.org/r/545211

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2019, 11:11 AM

• Matthias_Geisler_WMDE edited projects, added: Wikidata-Bridge-Sprint-8; removed: Wikidata-Bridge.Oct 29 2019, 10:43 AM

• Matthias_Geisler_WMDE moved this task from To do to Verification on the Wikidata-Bridge-Sprint-8 board.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 29 2019, 11:15 AM

@Charlie_WMDE please review and close :)

lookin' good \o/

header height too bigClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions

Description

Details

Related Objects

Event Timeline

header height too big
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions